From: Stefano Brivio <sbrivio@redhat.com>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: passt-dev@passt.top
Subject: Re: [PATCH] seccomp: Make seccomp.sh re-entrancy safe
Date: Mon, 26 Jun 2023 09:22:11 +0200 [thread overview]
Message-ID: <20230626092211.193e1965@elisabeth> (raw)
In-Reply-To: <20230621030637.640272-1-david@gibson.dropbear.id.au>
On Wed, 21 Jun 2023 13:06:37 +1000
David Gibson <david@gibson.dropbear.id.au> wrote:
> seccomp.sh generates seccomp.h piece by piece using >> directives. This
> means that if two instances of seccomp.h are run concurrently a corrupted
> version of seccomp.h will be generated. Amongst other problems this can
> cause spurious failures on clang-tidy.
>
> Alter seccomp.sh to build the output in a temporary file and atomic move it
> to seccomp.h, so concurrent invocations will still result in valud output.
>
> Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Applied.
--
Stefano
prev parent reply other threads:[~2023-06-26 7:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-21 3:06 [PATCH] seccomp: Make seccomp.sh re-entrancy safe David Gibson
2023-06-21 4:51 ` David Gibson
2023-06-26 7:22 ` Stefano Brivio [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230626092211.193e1965@elisabeth \
--to=sbrivio@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=passt-dev@passt.top \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).