From: Stefano Brivio <sbrivio@redhat.com>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: passt-dev@passt.top
Subject: Re: [PATCH v2] tap: Explicitly drop IPv4 fragments, and give a warning
Date: Fri, 7 Jul 2023 22:35:25 +0200 [thread overview]
Message-ID: <20230707223525.01ba0510@elisabeth> (raw)
In-Reply-To: <20230705043516.1237808-1-david@gibson.dropbear.id.au>
On Wed, 5 Jul 2023 14:35:16 +1000
David Gibson <david@gibson.dropbear.id.au> wrote:
> We don't handle defragmentation of IP packets coming from the tap side,
> and we're unlikely to any time soon (with our large MTU, it's not useful
> for practical use cases). Currently, however, we simply ignore the
> fragmentation flags and treat fragments as though they were whole IP
> packets. This isn't ideal and can lead to rather cryptic behaviour if we
> do receive IP fragments.
>
> Change the code to explicitly drop fragmented packets, and print a rate
> limited warning if we do encounter them.
>
> Link: https://bugs.passt.top/show_bug.cgi?id=62
>
> Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Applied.
--
Stefano
prev parent reply other threads:[~2023-07-07 20:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-05 4:35 [PATCH v2] tap: Explicitly drop IPv4 fragments, and give a warning David Gibson
2023-07-07 20:35 ` Stefano Brivio [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230707223525.01ba0510@elisabeth \
--to=sbrivio@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=passt-dev@passt.top \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).