public inbox for passt-dev@passt.top
 help / color / mirror / code / Atom feed
From: David Gibson <david@gibson.dropbear.id.au>
To: Stefano Brivio <sbrivio@redhat.com>, passt-dev@passt.top
Cc: David Gibson <david@gibson.dropbear.id.au>
Subject: [PATCH 3/3] Use static assertion to verify that union epoll_ref is the right size
Date: Tue,  1 Aug 2023 13:36:47 +1000	[thread overview]
Message-ID: <20230801033647.2135844-4-david@gibson.dropbear.id.au> (raw)
In-Reply-To: <20230801033647.2135844-1-david@gibson.dropbear.id.au>

union epoll_ref is used to subdivide the 64-bit data field in struct
epoll_event.  Thus it *must* fit within that field or we're likely to get
very subtle and nasty bugs.  C11 introduces the notion of static assertions
which we can use to verify this is the case at compile time.

Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
---
 passt.h | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/passt.h b/passt.h
index 8b7235a..edc4841 100644
--- a/passt.h
+++ b/passt.h
@@ -32,6 +32,8 @@ struct tap_l4_msg {
 union epoll_ref;
 
 #include <stdbool.h>
+#include <assert.h>
+#include <sys/epoll.h>
 
 #include "packet.h"
 #include "icmp.h"
@@ -64,6 +66,8 @@ union epoll_ref {
 	};
 	uint64_t u64;
 };
+static_assert(sizeof(union epoll_ref) <= sizeof(union epoll_data),
+	      "epoll_ref must have same size as epoll_data");
 
 #define TAP_BUF_BYTES							\
 	ROUND_DOWN(((ETH_MAX_MTU + sizeof(uint32_t)) * 128), PAGE_SIZE)
-- 
@@ -32,6 +32,8 @@ struct tap_l4_msg {
 union epoll_ref;
 
 #include <stdbool.h>
+#include <assert.h>
+#include <sys/epoll.h>
 
 #include "packet.h"
 #include "icmp.h"
@@ -64,6 +66,8 @@ union epoll_ref {
 	};
 	uint64_t u64;
 };
+static_assert(sizeof(union epoll_ref) <= sizeof(union epoll_data),
+	      "epoll_ref must have same size as epoll_data");
 
 #define TAP_BUF_BYTES							\
 	ROUND_DOWN(((ETH_MAX_MTU + sizeof(uint32_t)) * 128), PAGE_SIZE)
-- 
2.41.0


  parent reply	other threads:[~2023-08-01  3:36 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-01  3:36 [PATCH 0/3] RFC: Allow C11 extensions in the passt/pasta code David Gibson
2023-08-01  3:36 ` [PATCH 1/3] Allow C11 code, not just C99 code David Gibson
2023-08-01  3:36 ` [PATCH 2/3] Use C11 anonymous members to make poll refs less verbose to use David Gibson
2023-08-01  3:36 ` David Gibson [this message]
2023-08-01  8:15 ` [PATCH 0/3] RFC: Allow C11 extensions in the passt/pasta code Stefano Brivio
2023-08-02  4:47   ` David Gibson
2023-08-02  8:19     ` Stefano Brivio
2023-08-04  7:03 ` Stefano Brivio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230801033647.2135844-4-david@gibson.dropbear.id.au \
    --to=david@gibson.dropbear.id.au \
    --cc=passt-dev@passt.top \
    --cc=sbrivio@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://passt.top/passt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).