public inbox for passt-dev@passt.top
 help / color / mirror / code / Atom feed
From: David Gibson <david@gibson.dropbear.id.au>
To: passt-dev@passt.top, Stefano Brivio <sbrivio@redhat.com>
Cc: Paul Holzinger <pholzing@redhat.com>,
	David Gibson <david@gibson.dropbear.id.au>
Subject: [PATCH 0/3] Better report errors failing to open namespace tap device
Date: Wed,  2 Aug 2023 13:15:39 +1000	[thread overview]
Message-ID: <20230802031542.2726758-1-david@gibson.dropbear.id.au> (raw)

In https://github.com/containers/podman/issues/19428, pasta is failing
to open the namespace tap device.  Paul Holzinger correctly noted that
pasta isn't very helpful in this case, with no information beyond "it
failed".  He suggested a patch for that, however it wasn't quite
sufficient: errno may not be propagated back from the ephemeral thread
which enters the namespace, and even if it does the errno alone won't
tell us which of the possible failure points actually failed.

2/3 here is a more robust change to address the problem.  The other
patches are minor cleanups I noticed along the way.

Link: https://bugs.passt.top/show_bug.cgi?id=69

David Gibson (3):
  util: Make ns_enter() a void function and report setns() errors
  tap: More detailed error reporting in tap_ns_tun()
  tap: Remove unnecessary global tun_ns_fd

 conf.c |  3 ++-
 tap.c  | 33 ++++++++++++++++++---------------
 udp.c  |  6 ++----
 util.c |  8 +++-----
 util.h |  2 +-
 5 files changed, 26 insertions(+), 26 deletions(-)

-- 
2.41.0


             reply	other threads:[~2023-08-02  3:15 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-02  3:15 David Gibson [this message]
2023-08-02  3:15 ` [PATCH 1/3] util: Make ns_enter() a void function and report setns() errors David Gibson
2023-08-02  3:15 ` [PATCH 2/3] tap: More detailed error reporting in tap_ns_tun() David Gibson
2023-08-02  3:15 ` [PATCH 3/3] tap: Remove unnecessary global tun_ns_fd David Gibson
2023-08-04  7:04 ` [PATCH 0/3] Better report errors failing to open namespace tap device Stefano Brivio
2023-08-04  8:35   ` David Gibson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230802031542.2726758-1-david@gibson.dropbear.id.au \
    --to=david@gibson.dropbear.id.au \
    --cc=passt-dev@passt.top \
    --cc=pholzing@redhat.com \
    --cc=sbrivio@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://passt.top/passt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).