public inbox for passt-dev@passt.top
 help / color / mirror / code / Atom feed
From: David Gibson <david@gibson.dropbear.id.au>
To: passt-dev@passt.top, Stefano Brivio <sbrivio@redhat.com>
Cc: David Gibson <david@gibson.dropbear.id.au>
Subject: [PATCH v2 00/17] netlink fixes and cleanups
Date: Thu,  3 Aug 2023 17:19:39 +1000	[thread overview]
Message-ID: <20230803071956.3198452-1-david@gibson.dropbear.id.au> (raw)

We've had several bugs in the past that were quite tricky to debug,
but would have been much easier if we'd known that a netlink operation
had failed.  So, it would be desirable to actually detect and report
failures of netlink operations.  While working on that, I discovered
that there are a number of other issues ranging from very small to
medium sized with the way we use netlink.  This series addresses many
of them.

Link: https://bugs.passt.top/show_bug.cgi?id=60
Link: https://bugs.passt.top/show_bug.cgi?id=67

This series was tested as based on the pending patches adding C11
support, though I believe it trivially rebases onto current main.

Changes since v1:
 * Assorted minor fixes based on Stefano's review
 * Rebased on C11 branch

David Gibson (17):
  netlink: Split up functionality of nl_link()
  netlink: Split nl_addr() into separate operation functions
  netlink: Split nl_route() into separate operation functions
  netlink: Use struct in_addr for IPv4 addresses, not bare uint32_t
  netlink: Explicitly pass netlink sockets to operations
  netlink: Make nl_*_dup() use a separate datagram for each request
  netlink: Start sequence number from 1 instead of 0
  netlink: Treat send() or recv() errors as fatal
  netlink: Fill in netlink header fields from nl_req()
  netlink: Add nl_do() helper for simple operations with error checking
  netlink: Clearer reasoning about the netlink response buffer size
  netlink: Split nl_req() to allow processing multiple response
    datagrams
  netlink: Add nl_foreach_oftype to filter response message types
  netlink: Propagate errors for "set" operations
  netlink: Always process all responses to a netlink request
  netlink: Propagate errors for "dump" operations
  netlink: Propagate errors for "dup" operations

 conf.c    |  66 ++++-
 netlink.c | 843 ++++++++++++++++++++++++++++++++++--------------------
 netlink.h |  27 +-
 pasta.c   |  75 +++--
 4 files changed, 658 insertions(+), 353 deletions(-)

-- 
2.41.0


             reply	other threads:[~2023-08-03  7:20 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-03  7:19 David Gibson [this message]
2023-08-03  7:19 ` [PATCH v2 01/17] netlink: Split up functionality of nl_link() David Gibson
2023-08-03  7:19 ` [PATCH v2 02/17] netlink: Split nl_addr() into separate operation functions David Gibson
2023-08-03  7:19 ` [PATCH v2 03/17] netlink: Split nl_route() " David Gibson
2023-08-03  7:19 ` [PATCH v2 04/17] netlink: Use struct in_addr for IPv4 addresses, not bare uint32_t David Gibson
2023-08-03  7:19 ` [PATCH v2 05/17] netlink: Explicitly pass netlink sockets to operations David Gibson
2023-08-03  7:19 ` [PATCH v2 06/17] netlink: Make nl_*_dup() use a separate datagram for each request David Gibson
2023-08-03  7:19 ` [PATCH v2 07/17] netlink: Start sequence number from 1 instead of 0 David Gibson
2023-08-03  7:19 ` [PATCH v2 08/17] netlink: Treat send() or recv() errors as fatal David Gibson
2023-08-03  7:19 ` [PATCH v2 09/17] netlink: Fill in netlink header fields from nl_req() David Gibson
2023-08-03  7:19 ` [PATCH v2 10/17] netlink: Add nl_do() helper for simple operations with error checking David Gibson
2023-08-03  7:19 ` [PATCH v2 11/17] netlink: Clearer reasoning about the netlink response buffer size David Gibson
2023-08-03  7:19 ` [PATCH v2 12/17] netlink: Split nl_req() to allow processing multiple response datagrams David Gibson
2023-08-03  7:19 ` [PATCH v2 13/17] netlink: Add nl_foreach_oftype to filter response message types David Gibson
2023-08-03  7:19 ` [PATCH v2 14/17] netlink: Propagate errors for "set" operations David Gibson
2023-08-03  7:19 ` [PATCH v2 15/17] netlink: Always process all responses to a netlink request David Gibson
2023-08-03  7:19 ` [PATCH v2 16/17] netlink: Propagate errors for "dump" operations David Gibson
2023-08-03  7:19 ` [PATCH v2 17/17] netlink: Propagate errors for "dup" operations David Gibson
2023-08-04  7:04 ` [PATCH v2 00/17] netlink fixes and cleanups Stefano Brivio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230803071956.3198452-1-david@gibson.dropbear.id.au \
    --to=david@gibson.dropbear.id.au \
    --cc=passt-dev@passt.top \
    --cc=sbrivio@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://passt.top/passt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).