From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTP id 835995A026D for ; Fri, 4 Aug 2023 09:04:49 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1691132688; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FrurxusnESlV7z36iwC2CT4HclyO6PRGnXWb29QC2oA=; b=Isiv+YPB66ulD+8+p7yzXFQcERTyWK2hJfiwnynr9Bo/vyYFKBCDMxZuFdoSUBD+bjoceQ QXXulAJ2jhxQ7IOb1rvg+20EWrbJ68TtDsmFlG+63qLNjMraZIudSsf6fk0kj+egWlCkX0 vyB0XGDlg639Mf1gxY4ygUSljUM361g= Received: from mimecast-mx02.redhat.com (66.187.233.73 [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-9-37YzdS3PNAOXI1gyXeDMQQ-1; Fri, 04 Aug 2023 03:04:42 -0400 X-MC-Unique: 37YzdS3PNAOXI1gyXeDMQQ-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 804E43C0D857; Fri, 4 Aug 2023 07:04:42 +0000 (UTC) Received: from elisabeth (unknown [10.39.208.24]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D69861401C2E; Fri, 4 Aug 2023 07:04:41 +0000 (UTC) Date: Fri, 4 Aug 2023 09:04:32 +0200 From: Stefano Brivio To: David Gibson Subject: Re: [PATCH v2 00/17] netlink fixes and cleanups Message-ID: <20230804090432.26678264@elisabeth> In-Reply-To: <20230803071956.3198452-1-david@gibson.dropbear.id.au> References: <20230803071956.3198452-1-david@gibson.dropbear.id.au> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: ITRSOGANYKQC6SW3U5YKX4B4XZGVPRT5 X-Message-ID-Hash: ITRSOGANYKQC6SW3U5YKX4B4XZGVPRT5 X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Thu, 3 Aug 2023 17:19:39 +1000 David Gibson wrote: > We've had several bugs in the past that were quite tricky to debug, > but would have been much easier if we'd known that a netlink operation > had failed. So, it would be desirable to actually detect and report > failures of netlink operations. While working on that, I discovered > that there are a number of other issues ranging from very small to > medium sized with the way we use netlink. This series addresses many > of them. > > Link: https://bugs.passt.top/show_bug.cgi?id=60 > Link: https://bugs.passt.top/show_bug.cgi?id=67 > > This series was tested as based on the pending patches adding C11 > support, though I believe it trivially rebases onto current main. > > Changes since v1: > * Assorted minor fixes based on Stefano's review > * Rebased on C11 branch Applied (with minor formatting fixes in pasta_ns_conf()). -- Stefano