From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTP id B7AA15A0272 for ; Fri, 4 Aug 2023 09:04:53 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1691132692; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OlvBaJugfspG5HQ1D0lw6wb7c+3+IEbKdd05uqJOkM4=; b=i7NA+rlnnyfpF9ZXmaXN8X637B1Cvvd1JGSbtDCwvWPjnEAavlIKz/6iEnqpYysx44vNXo 799O2f2MbECjExJJbqORB3Nbmt5ciDXx4tYJTh3WHmosgZWPggaLrup65BAcXUB7U3Tkcr Uc1meeWiniT7TJuwg8M1vxw2TF2ZmKE= Received: from mimecast-mx02.redhat.com (66.187.233.73 [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-554-EGnncCMAO72wPlq1bcGOwQ-1; Fri, 04 Aug 2023 03:04:49 -0400 X-MC-Unique: EGnncCMAO72wPlq1bcGOwQ-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 215173C0D857; Fri, 4 Aug 2023 07:04:49 +0000 (UTC) Received: from elisabeth (unknown [10.39.208.24]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5C4C71121325; Fri, 4 Aug 2023 07:04:48 +0000 (UTC) Date: Fri, 4 Aug 2023 09:04:46 +0200 From: Stefano Brivio To: David Gibson Subject: Re: [PATCH 0/3] Better report errors failing to open namespace tap device Message-ID: <20230804090446.59043eb5@elisabeth> In-Reply-To: <20230802031542.2726758-1-david@gibson.dropbear.id.au> References: <20230802031542.2726758-1-david@gibson.dropbear.id.au> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: LYZFKVDH26M5W53PKADZCCNKHLORJKOP X-Message-ID-Hash: LYZFKVDH26M5W53PKADZCCNKHLORJKOP X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, Paul Holzinger X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed, 2 Aug 2023 13:15:39 +1000 David Gibson wrote: > In https://github.com/containers/podman/issues/19428, pasta is failing > to open the namespace tap device. Paul Holzinger correctly noted that > pasta isn't very helpful in this case, with no information beyond "it > failed". He suggested a patch for that, however it wasn't quite > sufficient: errno may not be propagated back from the ephemeral thread > which enters the namespace, and even if it does the errno alone won't > tell us which of the possible failure points actually failed. > > 2/3 here is a more robust change to address the problem. The other > patches are minor cleanups I noticed along the way. > > Link: https://bugs.passt.top/show_bug.cgi?id=69 > > David Gibson (3): > util: Make ns_enter() a void function and report setns() errors > tap: More detailed error reporting in tap_ns_tun() > tap: Remove unnecessary global tun_ns_fd Applied, too (no, I didn't forget about the flow tracking series :) I'm still reviewing it). -- Stefano