From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTP id 47C605A0271 for ; Sun, 13 Aug 2023 18:31:43 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1691944302; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lcovam2RZBksanYpbpljr/tGNEm1HKeAvi+yk3aUd+o=; b=WC5X/3rL76fAMyjtA/ujSJ/SeYPsd6wpVE+G116/fPLpW3/Lrs78GoIu8TiSS2n8eNjWDr bhsHz5j4FGq3zZ/r/luHFKddenoAE7U+docXa6TTFsU+wlk1MGVkSI4XeuyFxJ/xH+Zxaq upkTZbnKgspxjfaD648fSV1G2OpRWL8= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-159-7Xn52qL6M6ufemMNTsvYww-1; Sun, 13 Aug 2023 12:31:38 -0400 X-MC-Unique: 7Xn52qL6M6ufemMNTsvYww-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 0C63585CBE0; Sun, 13 Aug 2023 16:31:38 +0000 (UTC) Received: from elisabeth (unknown [10.39.208.5]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 567ED40C6F53; Sun, 13 Aug 2023 16:31:37 +0000 (UTC) Date: Sun, 13 Aug 2023 18:31:35 +0200 From: Stefano Brivio To: David Gibson Subject: Re: [PATCH v3 00/13] Clean up to tap errors and epoll dispatch Message-ID: <20230813183135.738a7e7b@elisabeth> In-Reply-To: <20230811051229.343838-1-david@gibson.dropbear.id.au> References: <20230811051229.343838-1-david@gibson.dropbear.id.au> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: ST3S4LYIQTXZT2SHO3D4D7AJTT3ESB6S X-Message-ID-Hash: ST3S4LYIQTXZT2SHO3D4D7AJTT3ESB6S X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri, 11 Aug 2023 15:12:16 +1000 David Gibson wrote: > Getting from an epoll event to the relevant handler function is > currently several levels of functions and tests. This series > simplifies this to be pretty close to a single switch on a value in > the epoll ref dispatching directly to the appropriate handler. > > Doing this requires some preliminary cleaning up of the handling of > errors or disconnects on the tap device. > > Changes since v2: > * Removed a (pre-existing) redundant close() and EPOLL_CTL_DEL in one > of the tap reset paths > * Fixed incorrect parameter to trace() message > > Changes since v1: > * Give listening TCP sockets their own reference type > * Fold "tap reset" series into this one > > Changes since v2 of tap reset series: > * More thorough cleanup of handling error events on the listening > Unix socket. > Changes since v1 of the tap reset series: > * Two extra patches that further clean up the reset path Applied, thanks! -- Stefano