From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTP id 3D70E5A0271 for ; Sun, 13 Aug 2023 18:31:57 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1691944316; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fNSqepVqx1EiKn2ddYei+JDZEr6WWAIYZN1QaAeGEpE=; b=iu0pCOS6PGAXdwS6bui1Ow0KB5dhoS6GXMHDZ5dxxCom4J99N8mHs5Zds86AqJkzYmqgzU qr66nMOu/va1/giO2hEHxCAXMB+hifcR1KQI40PuHGIU3x3EFAFh3+N5c5aklwTKCGsR+s 1pr7C2zLUX3WXrc79xhj04iGT1VJHVs= Received: from mimecast-mx02.redhat.com (66.187.233.73 [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-281-cl6RcJPcMIyiIT7jkiry9A-1; Sun, 13 Aug 2023 12:31:54 -0400 X-MC-Unique: cl6RcJPcMIyiIT7jkiry9A-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 8EF1329A9CA5; Sun, 13 Aug 2023 16:31:54 +0000 (UTC) Received: from elisabeth (unknown [10.39.208.5]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9EAB4140E917; Sun, 13 Aug 2023 16:31:53 +0000 (UTC) Date: Sun, 13 Aug 2023 18:31:51 +0200 From: Stefano Brivio To: David Gibson Subject: Re: [PATCH] conf: Demote overlapping port ranges error to a warning Message-ID: <20230813183151.34e60eae@elisabeth> In-Reply-To: <20230811073600.685128-1-david@gibson.dropbear.id.au> References: <20230811073600.685128-1-david@gibson.dropbear.id.au> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: RETZ3BOISY6I7X62YC6JZD4XGE4BRH2Y X-Message-ID-Hash: RETZ3BOISY6I7X62YC6JZD4XGE4BRH2Y X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, Daniel Rudolf X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri, 11 Aug 2023 17:36:00 +1000 David Gibson wrote: > We give a fatal error if the port ranges from any port forwarding > specifiers overlap. This occurs even if those port ranges are specifically > bound to different addresses, so there's not really any overlap. > > Right now, we can't 100% handle this case correctly, because our data > structures don't have a way to represent per-address forwarding. However, > there are a number of cases that will actually work just fine: e.g. mapping > the same port to the same port on two different addresses (say :: and > 127.0.0.1). > > We have long term plans to fix this properly, but that is still some time > away. For the time being, demote this error to a warning so that the cases > that already work will be allowed. > > Link: https://bugs.passt.top/show_bug.cgi?id=56 > Signed-off-by: David Gibson Also applied. -- Stefano