From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from gandalf.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by passt.top (Postfix) with ESMTPS id 42CD85A0274 for ; Tue, 15 Aug 2023 05:51:39 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=201602; t=1692071493; bh=J/7egY0hV5RN6jeItXr3VKRrQqlXtIHqBF/9n5qzznM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Bxr8YDhK0f7SMfnccanP24bWuD58HlEsIGPF41n6mOlswFdePKloEI055QxiHmtGf UWzpMAfjFP3QIzagd5a/m1m51QWg/Xoni02Kqhz7QeHRrkyoofIxF/bq6+7+PaQS91 yeKm5BlqmYYiUPnTPeuqg2yc6lV1tQsYEHjQdD/Q= Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4RPy4P1mVdz4wxm; Tue, 15 Aug 2023 13:51:33 +1000 (AEST) From: David Gibson To: Stefano Brivio , passt-dev@passt.top Subject: [PATCH 1/3] netlink: Remove redundant check on nlmsg_type Date: Tue, 15 Aug 2023 13:51:27 +1000 Message-ID: <20230815035129.1942905-2-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230815035129.1942905-1-david@gibson.dropbear.id.au> References: <20230815035129.1942905-1-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Message-ID-Hash: NVSXRYN6RDP6RBNQSOWU3VPSZ7VUPYZQ X-Message-ID-Hash: NVSXRYN6RDP6RBNQSOWU3VPSZ7VUPYZQ X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: David Gibson X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: In the loop within nl_addr_dup() we check and skip for any messages that aren't of type RTM_NEWADDR. This is a leftover that was missed in the recent big netlink cleanup. In fact we already check for the message type in the nl_foreach_oftype() macro, so the explicit test is redudant. Remove it. Signed-off-by: David Gibson --- netlink.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/netlink.c b/netlink.c index 1226379..ff44e13 100644 --- a/netlink.c +++ b/netlink.c @@ -669,9 +669,6 @@ int nl_addr_dup(int s_src, unsigned int ifi_src, struct rtattr *rta; size_t na; - if (nh->nlmsg_type != RTM_NEWADDR) - continue; - ifa = (struct ifaddrmsg *)NLMSG_DATA(nh); if (rc < 0 || ifa->ifa_scope == RT_SCOPE_LINK || -- 2.41.0