From: Stefano Brivio <sbrivio@redhat.com>
To: passt-dev@passt.top
Cc: "'Richard W . M . Jones'" <rjones@redhat.com>,
David Gibson <david@gibson.dropbear.id.au>
Subject: [PATCH 1/7] fedora: Install pasta as hard link to ensure SELinux file context match
Date: Wed, 16 Aug 2023 08:00:32 +0200 [thread overview]
Message-ID: <20230816060038.870746-2-sbrivio@redhat.com> (raw)
In-Reply-To: <20230816060038.870746-1-sbrivio@redhat.com>
The Makefile installs symbolic links by default, which actually
worked at some point (not by design) with SELinux, but at least on
recent kernel versions it doesn't anymore: override pasta (and
pasta.avx2) with hard links.
Otherwise, even if the links are labeled as pasta_exec_t, SELinux
will "resolve" them to passt_exec_t, and we'll have pasta running as
passt_t instead of pasta_t.
Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
---
contrib/fedora/passt.spec | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/contrib/fedora/passt.spec b/contrib/fedora/passt.spec
index 8d28ef6..49b4860 100644
--- a/contrib/fedora/passt.spec
+++ b/contrib/fedora/passt.spec
@@ -55,9 +55,13 @@ This package adds SELinux enforcement to passt(1) and pasta(1).
%install
%make_install DESTDIR=%{buildroot} prefix=%{_prefix} bindir=%{_bindir} mandir=%{_mandir} docdir=%{_docdir}/%{name}
+# The Makefile simply links pasta to passt, but we need to copy the binary for
+# SELinux file contexts to work as intended. Same with pasta.avx2 if present.
+install -p -m 755 %{buildroot}%{_bindir}/passt %{buildroot}%{_bindir}/pasta
%ifarch x86_64
ln -sr %{buildroot}%{_mandir}/man1/passt.1 %{buildroot}%{_mandir}/man1/passt.avx2.1
ln -sr %{buildroot}%{_mandir}/man1/pasta.1 %{buildroot}%{_mandir}/man1/pasta.avx2.1
+install -p -m 755 %{buildroot}%{_bindir}/passt.avx2 %{buildroot}%{_bindir}/pasta.avx2
%endif
pushd contrib/selinux
--
@@ -55,9 +55,13 @@ This package adds SELinux enforcement to passt(1) and pasta(1).
%install
%make_install DESTDIR=%{buildroot} prefix=%{_prefix} bindir=%{_bindir} mandir=%{_mandir} docdir=%{_docdir}/%{name}
+# The Makefile simply links pasta to passt, but we need to copy the binary for
+# SELinux file contexts to work as intended. Same with pasta.avx2 if present.
+install -p -m 755 %{buildroot}%{_bindir}/passt %{buildroot}%{_bindir}/pasta
%ifarch x86_64
ln -sr %{buildroot}%{_mandir}/man1/passt.1 %{buildroot}%{_mandir}/man1/passt.avx2.1
ln -sr %{buildroot}%{_mandir}/man1/pasta.1 %{buildroot}%{_mandir}/man1/pasta.avx2.1
+install -p -m 755 %{buildroot}%{_bindir}/passt.avx2 %{buildroot}%{_bindir}/pasta.avx2
%endif
pushd contrib/selinux
--
2.39.2
next prev parent reply other threads:[~2023-08-16 6:00 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-16 6:00 [PATCH 0/7] Extensive bandaging for SELinux policy issues, old and new Stefano Brivio
2023-08-16 6:00 ` Stefano Brivio [this message]
2023-08-16 9:03 ` [PATCH 1/7] fedora: Install pasta as hard link to ensure SELinux file context match Richard W.M. Jones
2023-08-16 9:08 ` Stefano Brivio
2023-08-16 6:00 ` [PATCH 2/7] selinux: Use explicit paths for binaries in file context Stefano Brivio
2023-08-16 9:04 ` Richard W.M. Jones
2023-08-16 6:00 ` [PATCH 3/7] selinux: Fix user namespace creation after breaking kernel change Stefano Brivio
2023-08-16 9:05 ` Richard W.M. Jones
2023-08-16 6:00 ` [PATCH 4/7] selinux: Update policy to fix user/group settings Stefano Brivio
2023-08-16 9:06 ` Richard W.M. Jones
2023-08-16 6:00 ` [PATCH 5/7] selinux: Add rules for sysctl and /proc/net accesses Stefano Brivio
2023-08-16 9:10 ` Richard W.M. Jones
2023-08-16 6:00 ` [PATCH 6/7] selinux: Allow pasta_t to read nsfs entries Stefano Brivio
2023-08-16 9:10 ` Richard W.M. Jones
2023-08-16 6:00 ` [PATCH 7/7] selinux: Fix domain transitions for typical commands pasta might run Stefano Brivio
2023-08-16 9:12 ` Richard W.M. Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230816060038.870746-2-sbrivio@redhat.com \
--to=sbrivio@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=passt-dev@passt.top \
--cc=rjones@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).