From: Stefano Brivio <sbrivio@redhat.com>
To: passt-dev@passt.top
Cc: David Gibson <david@gibson.dropbear.id.au>
Subject: [PATCH] tap: Fix format specifier in tap4_is_fragment() warning
Date: Wed, 16 Aug 2023 08:26:23 +0200 [thread overview]
Message-ID: <20230816062623.883685-1-sbrivio@redhat.com> (raw)
Spotted by Coverity, relatively harmless.
Fixes: e01759e2fab0 ("tap: Explicitly drop IPv4 fragments, and give a warning")
Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
---
tap.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tap.c b/tap.c
index a6f8692..760deb7 100644
--- a/tap.c
+++ b/tap.c
@@ -561,7 +561,8 @@ static bool tap4_is_fragment(const struct iphdr *iph,
num_dropped++;
if (now->tv_sec - last_message > FRAGMENT_MSG_RATE) {
- warn("Can't process IPv4 fragments (%lu dropped)", num_dropped);
+ warn("Can't process IPv4 fragments (%u dropped)",
+ num_dropped);
last_message = now->tv_sec;
num_dropped = 0;
}
--
@@ -561,7 +561,8 @@ static bool tap4_is_fragment(const struct iphdr *iph,
num_dropped++;
if (now->tv_sec - last_message > FRAGMENT_MSG_RATE) {
- warn("Can't process IPv4 fragments (%lu dropped)", num_dropped);
+ warn("Can't process IPv4 fragments (%u dropped)",
+ num_dropped);
last_message = now->tv_sec;
num_dropped = 0;
}
--
2.39.2
next reply other threads:[~2023-08-16 6:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-16 6:26 Stefano Brivio [this message]
2023-08-16 6:58 ` [PATCH] tap: Fix format specifier in tap4_is_fragment() warning David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230816062623.883685-1-sbrivio@redhat.com \
--to=sbrivio@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=passt-dev@passt.top \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).