From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTP id 865EE5A026F for ; Wed, 16 Aug 2023 11:05:15 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1692176714; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=MEfdHsO3Wqzh8yUyDN1ZkfgulhxfRaOHlcTOlxxVj4c=; b=FQQCWxDlcTV/rIv4gaf7AIVLGRbEsPBj1KVx5wbg0O6vETLpM95tgjt2UL+/lzyei7ja/q cAj3HmWOWrRrDL5JJujpFBxYr2ltHPP5U1TPX4FQqRi11HXmtFQVCDjIPy9tMZcC0mkhv9 FWF1/bqanPe7jSw5F4j/JL82AAfiboY= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-140-XsNfb5inMR6eJXfmbB3qMg-1; Wed, 16 Aug 2023 05:05:11 -0400 X-MC-Unique: XsNfb5inMR6eJXfmbB3qMg-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id B06E3856F67; Wed, 16 Aug 2023 09:05:10 +0000 (UTC) Received: from localhost (unknown [10.42.28.15]) by smtp.corp.redhat.com (Postfix) with ESMTP id 681C11121314; Wed, 16 Aug 2023 09:05:10 +0000 (UTC) Date: Wed, 16 Aug 2023 10:05:09 +0100 From: "Richard W.M. Jones" To: Stefano Brivio Subject: Re: [PATCH 3/7] selinux: Fix user namespace creation after breaking kernel change Message-ID: <20230816090509.GC7636@redhat.com> References: <20230816060038.870746-1-sbrivio@redhat.com> <20230816060038.870746-4-sbrivio@redhat.com> MIME-Version: 1.0 In-Reply-To: <20230816060038.870746-4-sbrivio@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Message-ID-Hash: QE7U4DEM4KLNVJI5MSCXB64OJ4HXQ4BC X-Message-ID-Hash: QE7U4DEM4KLNVJI5MSCXB64OJ4HXQ4BC X-MailFrom: rjones@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, David Gibson X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed, Aug 16, 2023 at 08:00:34AM +0200, Stefano Brivio wrote: > Kernel commit ed5d44d42c95 ("selinux: Implement userns_create hook") > seems to just introduce a new functionality, but given that SELinux > implements a form of mandatory access control, introducing the new > permission breaks any application (shipping with SELinux policies) > that needs to create user namespaces, such as passt and pasta for > sandboxing purposes. > > Add the new 'allow' rules. They appear to be backward compatible, > kernel-wise, and the policy now requires the new 'user_namespace' > class to build, but that's something distributions already ship. > > Reported-by: Richard W.M. Jones > Signed-off-by: Stefano Brivio > --- > contrib/selinux/passt.te | 2 ++ > contrib/selinux/pasta.te | 2 ++ > 2 files changed, 4 insertions(+) > > diff --git a/contrib/selinux/passt.te b/contrib/selinux/passt.te > index 687ae40..5868a41 100644 > --- a/contrib/selinux/passt.te > +++ b/contrib/selinux/passt.te > @@ -51,6 +51,7 @@ require { > > class capability sys_tty_config; > class cap_userns { setpcap sys_admin sys_ptrace }; > + class user_namespace create; > } > > type passt_t; > @@ -90,6 +91,7 @@ allow syslogd_t self:cap_userns sys_ptrace; > allow passt_t self:process setcap; > allow passt_t self:capability { sys_tty_config setpcap net_bind_service }; > allow passt_t self:cap_userns { setpcap sys_admin sys_ptrace }; > +allow passt_t self:user_namespace create; > > allow passt_t proc_net_t:file read; > allow passt_t net_conf_t:file { open read }; > diff --git a/contrib/selinux/pasta.te b/contrib/selinux/pasta.te > index 367d09f..645ccee 100644 > --- a/contrib/selinux/pasta.te > +++ b/contrib/selinux/pasta.te > @@ -80,6 +80,7 @@ require { > type init_t; > > class cap_userns { setpcap sys_admin sys_ptrace net_bind_service net_admin }; > + class user_namespace create; > } > > type pasta_t; > @@ -104,6 +105,7 @@ init_daemon_domain(pasta_t, pasta_exec_t) > > allow pasta_t self:capability { setpcap net_bind_service sys_tty_config dac_read_search net_admin sys_resource }; > allow pasta_t self:cap_userns { setpcap sys_admin sys_ptrace net_admin net_bind_service }; > +allow pasta_t self:user_namespace create; > > allow pasta_t bin_t:file { execute execute_no_trans map }; > allow pasta_t nsfs_t:file { open read }; Looks sensible: Reviewed-by: Richard W.M. Jones -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-p2v converts physical machines to virtual machines. Boot with a live CD or over the network (PXE) and turn machines into KVM guests. http://libguestfs.org/virt-v2v