From: "Richard W.M. Jones" <rjones@redhat.com>
To: Stefano Brivio <sbrivio@redhat.com>
Cc: passt-dev@passt.top, David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [PATCH 5/7] selinux: Add rules for sysctl and /proc/net accesses
Date: Wed, 16 Aug 2023 10:10:32 +0100 [thread overview]
Message-ID: <20230816091032.GE7636@redhat.com> (raw)
In-Reply-To: <20230816060038.870746-6-sbrivio@redhat.com>
On Wed, Aug 16, 2023 at 08:00:36AM +0200, Stefano Brivio wrote:
> That's what we actually need to check networking-related sysctls,
> to scan for bound ports, and to manipulate bits of network
> configuration inside pasta's target namespaces.
>
> Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
> ---
> contrib/selinux/passt.te | 1 +
> contrib/selinux/pasta.te | 3 +++
> 2 files changed, 4 insertions(+)
>
> diff --git a/contrib/selinux/passt.te b/contrib/selinux/passt.te
> index a0c0526..948d1b1 100644
> --- a/contrib/selinux/passt.te
> +++ b/contrib/selinux/passt.te
> @@ -101,6 +101,7 @@ allow passt_t net_conf_t:file { open read };
> allow passt_t net_conf_t:lnk_file read;
> allow passt_t tmp_t:sock_file { create unlink write };
> allow passt_t self:netlink_route_socket { bind create nlmsg_read read write setopt };
> +kernel_search_network_sysctl(passt_t)
>
> corenet_tcp_bind_all_nodes(passt_t)
> corenet_udp_bind_all_nodes(passt_t)
> diff --git a/contrib/selinux/pasta.te b/contrib/selinux/pasta.te
> index 28265dc..b3ddc6a 100644
> --- a/contrib/selinux/pasta.te
> +++ b/contrib/selinux/pasta.te
> @@ -133,6 +133,7 @@ allow syslogd_t self:cap_userns sys_ptrace;
> allow pasta_t proc_net_t:file { open read };
> allow pasta_t net_conf_t:file { open read };
> allow pasta_t self:netlink_route_socket { bind create nlmsg_read nlmsg_write setopt read write };
> +kernel_search_network_sysctl(pasta_t)
>
> allow pasta_t tmp_t:sock_file { create unlink write };
>
> @@ -186,4 +187,6 @@ allow pasta_t sysctl_net_t:dir search;
> allow pasta_t sysctl_net_t:file { open write };
> allow pasta_t kernel_t:system module_request;
>
> +allow pasta_t net_conf_t:lnk_file read;
> +allow pasta_t proc_net_t:lnk_file read;
Acked-by: Richard W.M. Jones <rjones@redhat.com>
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
Fedora Windows cross-compiler. Compile Windows programs, test, and
build Windows installers. Over 100 libraries supported.
http://fedoraproject.org/wiki/MinGW
next prev parent reply other threads:[~2023-08-16 9:10 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-16 6:00 [PATCH 0/7] Extensive bandaging for SELinux policy issues, old and new Stefano Brivio
2023-08-16 6:00 ` [PATCH 1/7] fedora: Install pasta as hard link to ensure SELinux file context match Stefano Brivio
2023-08-16 9:03 ` Richard W.M. Jones
2023-08-16 9:08 ` Stefano Brivio
2023-08-16 6:00 ` [PATCH 2/7] selinux: Use explicit paths for binaries in file context Stefano Brivio
2023-08-16 9:04 ` Richard W.M. Jones
2023-08-16 6:00 ` [PATCH 3/7] selinux: Fix user namespace creation after breaking kernel change Stefano Brivio
2023-08-16 9:05 ` Richard W.M. Jones
2023-08-16 6:00 ` [PATCH 4/7] selinux: Update policy to fix user/group settings Stefano Brivio
2023-08-16 9:06 ` Richard W.M. Jones
2023-08-16 6:00 ` [PATCH 5/7] selinux: Add rules for sysctl and /proc/net accesses Stefano Brivio
2023-08-16 9:10 ` Richard W.M. Jones [this message]
2023-08-16 6:00 ` [PATCH 6/7] selinux: Allow pasta_t to read nsfs entries Stefano Brivio
2023-08-16 9:10 ` Richard W.M. Jones
2023-08-16 6:00 ` [PATCH 7/7] selinux: Fix domain transitions for typical commands pasta might run Stefano Brivio
2023-08-16 9:12 ` Richard W.M. Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230816091032.GE7636@redhat.com \
--to=rjones@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=passt-dev@passt.top \
--cc=sbrivio@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).