public inbox for passt-dev@passt.top
 help / color / mirror / code / Atom feed
From: David Gibson <david@gibson.dropbear.id.au>
To: Stefano Brivio <sbrivio@redhat.com>, passt-dev@passt.top
Cc: David Gibson <david@gibson.dropbear.id.au>
Subject: [PATCH v3 4/9] tcp: Consistent usage of ports in tcp_seq_init()
Date: Tue, 22 Aug 2023 12:11:25 +1000	[thread overview]
Message-ID: <20230822021130.450542-5-david@gibson.dropbear.id.au> (raw)
In-Reply-To: <20230822021130.450542-1-david@gibson.dropbear.id.au>

In tcp_seq_init() the meaning of "src" and "dst" isn't really clear since
it's used for connections in both directions.  However, these values are
just feeding a hash, so as long as we're consistent and include all the
information we want, it doesn't really matter.

Oddly, for the "src" side we supply the (tap side) forwarding address but
the (tap side) endpoint port.  This again doesn't really matter, but it's
confusing.  So swap this with dstport, so "src" is always forwarding
and "dst" is always endpoint.

Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
---
 tcp.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tcp.c b/tcp.c
index 74bf744..56634c9 100644
--- a/tcp.c
+++ b/tcp.c
@@ -1857,8 +1857,8 @@ static void tcp_seq_init(const struct ctx *c, struct tcp_tap_conn *conn,
 		in_port_t dstport;
 	} __attribute__((__packed__)) in = {
 		.src = conn->faddr,
-		.srcport = conn->eport,
-		.dstport = conn->fport,
+		.srcport = conn->fport,
+		.dstport = conn->eport,
 	};
 	uint32_t ns, seq = 0;
 
-- 
@@ -1857,8 +1857,8 @@ static void tcp_seq_init(const struct ctx *c, struct tcp_tap_conn *conn,
 		in_port_t dstport;
 	} __attribute__((__packed__)) in = {
 		.src = conn->faddr,
-		.srcport = conn->eport,
-		.dstport = conn->fport,
+		.srcport = conn->fport,
+		.dstport = conn->eport,
 	};
 	uint32_t ns, seq = 0;
 
-- 
2.41.0


  parent reply	other threads:[~2023-08-22  2:11 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-22  2:11 [PATCH v3 0/9] Flow Table Preliminaries David Gibson
2023-08-22  2:11 ` [PATCH v3 1/9] tap: Don't clobber source address in tap6_handler() David Gibson
2023-08-22  2:11 ` [PATCH v3 2/9] tap: Pass source address to protocol handler functions David Gibson
2023-08-22  2:11 ` [PATCH v3 3/9] tcp: More precise terms for addresses and ports David Gibson
2023-08-22  2:11 ` David Gibson [this message]
2023-08-22  2:11 ` [PATCH v3 5/9] tcp, udp: Don't include destination address in partially precomputed csums David Gibson
2023-08-22  2:11 ` [PATCH v3 6/9] tcp, udp: Don't pre-fill IPv4 destination address in headers David Gibson
2023-08-22  2:11 ` [PATCH v3 7/9] tcp: Move in_epoll flag out of common connection structure David Gibson
2023-08-22  2:11 ` [PATCH v3 8/9] inany: Add missing double include guard to inany.h David Gibson
2023-08-22  2:11 ` [PATCH v3 9/9] tcp: Remove broken pressure calculations for tcp_defer_handler() David Gibson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230822021130.450542-5-david@gibson.dropbear.id.au \
    --to=david@gibson.dropbear.id.au \
    --cc=passt-dev@passt.top \
    --cc=sbrivio@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://passt.top/passt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).