From: Stefano Brivio <sbrivio@redhat.com>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: passt-dev@passt.top
Subject: Re: [PATCH v4 1/9] tap: Don't clobber source address in tap6_handler()
Date: Tue, 22 Aug 2023 10:46:24 +0200 [thread overview]
Message-ID: <20230822104612.7a138ec2@elisabeth> (raw)
In-Reply-To: <20230822053000.1118063-2-david@gibson.dropbear.id.au>
On Tue, 22 Aug 2023 15:29:52 +1000
David Gibson <david@gibson.dropbear.id.au> wrote:
> In tap6_handler() saddr is initialized to the IPv6 source address from the
> incoming packet. However part way through, but before organizing the
> packet into a "sequence" we set it unconditionally to the guest's assigned
> address. We don't do anything equivalent for IPv4.
This was there from the beginning, and the reason, if I recall
correctly, is that a guest, depending on how far it got in its
configuration, might suddenly switch from using a link-local to a
global unicast address -- and we didn't handle that in TCP routines.
This should be fixed now, though, and:
> This doesn't make a lot of sense: if the guest is using a different source
> address it makes sense to consider these different sequences of packets and
> we shouldn't try to combine them together.
...right, that would be the wrong place anyway.
--
Stefano
next prev parent reply other threads:[~2023-08-22 8:46 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-22 5:29 [PATCH v4 0/9] Flow Table Preliminaries David Gibson
2023-08-22 5:29 ` [PATCH v4 1/9] tap: Don't clobber source address in tap6_handler() David Gibson
2023-08-22 8:46 ` Stefano Brivio [this message]
2023-08-22 5:29 ` [PATCH v4 2/9] tap: Pass source address to protocol handler functions David Gibson
2023-08-22 5:29 ` [PATCH v4 3/9] tcp: More precise terms for addresses and ports David Gibson
2023-08-22 5:29 ` [PATCH v4 4/9] tcp: Consistent usage of ports in tcp_seq_init() David Gibson
2023-08-22 8:46 ` Stefano Brivio
2023-08-22 5:29 ` [PATCH v4 5/9] tcp, udp: Don't include destination address in partially precomputed csums David Gibson
2023-08-22 8:46 ` Stefano Brivio
2023-08-22 5:29 ` [PATCH v4 6/9] tcp, udp: Don't pre-fill IPv4 destination address in headers David Gibson
2023-08-22 5:29 ` [PATCH v4 7/9] tcp: Move in_epoll flag out of common connection structure David Gibson
2023-08-22 5:29 ` [PATCH v4 8/9] inany: Add missing double include guard to inany.h David Gibson
2023-08-22 5:30 ` [PATCH v4 9/9] tcp: Remove broken pressure calculations for tcp_defer_handler() David Gibson
2023-08-22 12:05 ` [PATCH v4 0/9] Flow Table Preliminaries Stefano Brivio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230822104612.7a138ec2@elisabeth \
--to=sbrivio@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=passt-dev@passt.top \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).