From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTP id 354C45A026F for ; Tue, 22 Aug 2023 10:46:38 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1692693997; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8vjotcx4Iq2UD58JOMo03a2Yup1vR8Fo9G4XYIMadvs=; b=FsmBmqOVogABloEtcBqPZvx28LrQVO45WUt92hMf/hMUAOeJe3BqM5oqeHowhak78MJH4c I3wHe7CMsWahpvzWfzKw9CCCW+BXoKol2zaMzbHmwVzDUTABVQr9t0eoMKxERXdJfiAo17 +C2U6XEO0stkxFm3GKz8ZOuZ7Z5Rmik= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-235-zkmCYoZkOOa-cVGvj9fSTw-1; Tue, 22 Aug 2023 04:46:35 -0400 X-MC-Unique: zkmCYoZkOOa-cVGvj9fSTw-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id D3D6D101A52E; Tue, 22 Aug 2023 08:46:34 +0000 (UTC) Received: from elisabeth (unknown [10.39.208.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 293351121319; Tue, 22 Aug 2023 08:46:33 +0000 (UTC) Date: Tue, 22 Aug 2023 10:46:32 +0200 From: Stefano Brivio To: David Gibson Subject: Re: [PATCH v4 4/9] tcp: Consistent usage of ports in tcp_seq_init() Message-ID: <20230822104632.09dee717@elisabeth> In-Reply-To: <20230822053000.1118063-5-david@gibson.dropbear.id.au> References: <20230822053000.1118063-1-david@gibson.dropbear.id.au> <20230822053000.1118063-5-david@gibson.dropbear.id.au> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: UD3XWZPQKPW6UIBS2GIT2Z3W5XIZSISC X-Message-ID-Hash: UD3XWZPQKPW6UIBS2GIT2Z3W5XIZSISC X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Tue, 22 Aug 2023 15:29:55 +1000 David Gibson wrote: > In tcp_seq_init() the meaning of "src" and "dst" isn't really clear since > it's used for connections in both directions. However, these values are > just feeding a hash, so as long as we're consistent and include all the > information we want, it doesn't really matter. > > Oddly, for the "src" side we supply the (tap side) forwarding address but > the (tap side) endpoint port. This again doesn't really matter, but it's > confusing. Oops, yes, dropping the only comment I had to 3/9... -- Stefano