Re: [PATCH] dhcp: support BOOTP clients

[Stefano Brivio <sbrivio@redhat.com>]

On Tue, 29 Aug 2023 14:14:06 +0500
Stas Sergeev <stsp2@yandex.ru> wrote:

> BOOTP clients do not use tagged messages for requests.
> As such, any message without the DHCP option 53, should be
> considered a BOOTP request.
> 
> Signed-off-by: Stas Sergeev <stsp2@yandex.ru>
> ---
>  dhcp.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/dhcp.c b/dhcp.c
> index d04648c..c1ac95e 100644
> --- a/dhcp.c
> +++ b/dhcp.c
> @@ -323,8 +323,8 @@ int dhcp(const struct ctx *c, const struct pool *p)
>  	if (opts[53].c[0] == DHCPDISCOVER) {
>  		info("DHCP: offer to discover");
>  		opts[53].s[0] = DHCPOFFER;
> -	} else if (opts[53].c[0] == DHCPREQUEST) {
> -		info("DHCP: ack to request");
> +	} else if (opts[53].c[0] == DHCPREQUEST || !opts[53].clen) {
> +		info("%s: ack to request", opts[53].clen ? "DHCP" : "BOOTP");
>  		opts[53].s[0] = DHCPACK;
>  	} else {
>  		return -1;

Also applied.

-- 
Stefano