From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from gandalf.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by passt.top (Postfix) with ESMTPS id 215C35A027A for ; Fri, 8 Sep 2023 03:50:03 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=201602; t=1694137797; bh=85GKrnRtP8h5nvW81hZiyg06ffOoptDrl/mG2eBXrSc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=o30sKqOvgpvgLZkJAQ2RvAegf7+zkrVT4UV1X5Sm9YVxhZr5WuT6Ti+F45uiwWWvl XlhGepxmdHhPA9K9rlPRHCLUYuwJYqMJxBFuwRuhuBxFgO8m1ewMx1f1bS9rJHDD5W vbN1JVIFkeqJj19+aUAFGxt9VxKxWNlf1CnhTztQ= Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4RhfF10sw5z4xGM; Fri, 8 Sep 2023 11:49:57 +1000 (AEST) From: David Gibson To: passt-dev@passt.top, Stefano Brivio Subject: [PATCH 7/8] tcp: Consolidate paths where we initiate reset on tap interface Date: Fri, 8 Sep 2023 11:49:52 +1000 Message-ID: <20230908014953.822952-8-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230908014953.822952-1-david@gibson.dropbear.id.au> References: <20230908014953.822952-1-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Message-ID-Hash: 2P75FXFJDB72K2D65UDCP2JRVAHDS5SS X-Message-ID-Hash: 2P75FXFJDB72K2D65UDCP2JRVAHDS5SS X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: jlesev@gmail.com, David Gibson X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: There are a number of conditions where we will issue a TCP RST in response to something unexpected we received from the tap interface. These occur in both tcp_data_from_tap() and tcp_tap_handler(). In tcp_tap_handler() use a 'goto out of line' technique to consolidate all these paths into one place. For the tcp_data_from_tap() cases use a negative return code and direct that to the same path in tcp_tap_handler(), its caller. In this case we want to discard all remaining packets in the batch we have received: even if they're otherwise good, they'll be invalidated when the guest receives the RST we're sending. This is subtly different from the case where we *receive* an RST, where we could in theory get a new SYN immediately afterwards. Clarify that with a common on the now common reset path. Signed-off-by: David Gibson --- tcp.c | 47 +++++++++++++++++++++++++---------------------- 1 file changed, 25 insertions(+), 22 deletions(-) diff --git a/tcp.c b/tcp.c index a1b5a72..c76df73 100644 --- a/tcp.c +++ b/tcp.c @@ -2323,17 +2323,13 @@ static int tcp_data_from_tap(struct ctx *c, struct tcp_tap_conn *conn, size_t off; th = packet_get(p, i, 0, sizeof(*th), &len); - if (!th) { - tcp_rst(c, conn); - return p->count - idx; - } + if (!th) + return -1; len += sizeof(*th); off = th->doff * 4UL; - if (off < sizeof(*th) || off > len) { - tcp_rst(c, conn); - return p->count - idx; - } + if (off < sizeof(*th) || off > len) + return -1; if (th->rst) { conn_event(c, conn, CLOSED); @@ -2449,9 +2445,9 @@ eintr: if (errno == EAGAIN || errno == EWOULDBLOCK) { tcp_send_flag(c, conn, ACK_IF_NEEDED); return p->count - idx; + } - tcp_rst(c, conn); - return p->count - idx; + return -1; } if (n < (int)(seq_from_tap - conn->seq_from_tap)) { @@ -2580,20 +2576,18 @@ int tcp_tap_handler(struct ctx *c, int af, const void *saddr, const void *daddr, /* Establishing connection from socket */ if (conn->events & SOCK_ACCEPTED) { - if (th->syn && th->ack && !th->fin) + if (th->syn && th->ack && !th->fin) { tcp_conn_from_sock_finish(c, conn, th, opts, optlen); - else - tcp_rst(c, conn); + return 1; + } - return 1; + goto reset; } /* Establishing connection from tap */ if (conn->events & TAP_SYN_RCVD) { - if (!(conn->events & TAP_SYN_ACK_SENT)) { - tcp_rst(c, conn); - return p->count - idx; - } + if (!(conn->events & TAP_SYN_ACK_SENT)) + goto reset; conn_event(c, conn, ESTABLISHED); @@ -2607,10 +2601,8 @@ int tcp_tap_handler(struct ctx *c, int af, const void *saddr, const void *daddr, return p->count - idx; } - if (!th->ack) { - tcp_rst(c, conn); - return p->count - idx; - } + if (!th->ack) + goto reset; tcp_clamp_window(c, conn, ntohs(th->window)); @@ -2633,6 +2625,9 @@ int tcp_tap_handler(struct ctx *c, int af, const void *saddr, const void *daddr, /* Established connections accepting data from tap */ count = tcp_data_from_tap(c, conn, p, idx); + if (count == -1) + goto reset; + if (conn->seq_ack_to_tap != conn->seq_from_tap) ack_due = 1; @@ -2647,6 +2642,14 @@ int tcp_tap_handler(struct ctx *c, int af, const void *saddr, const void *daddr, conn_flag(c, conn, ACK_TO_TAP_DUE); return count; + +reset: + /* Something's gone wrong, so reset the connection. We discard + * remaining packets in the batch, since they'd be invalidated when our + * RST is received, even if otherwise good. + */ + tcp_rst(c, conn); + return p->count - idx; } /** -- 2.41.0