From: Stefano Brivio <sbrivio@redhat.com>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: passt-dev@passt.top, jlesev@gmail.com
Subject: Re: [PATCH 0/8] Fix a number of bugs with handling of TCP packets from tap
Date: Fri, 8 Sep 2023 17:27:01 +0200 [thread overview]
Message-ID: <20230908172647.1b081e80@elisabeth> (raw)
In-Reply-To: <20230908014953.822952-1-david@gibson.dropbear.id.au>
On Fri, 8 Sep 2023 11:49:45 +1000
David Gibson <david@gibson.dropbear.id.au> wrote:
> In the course of investigating bug 68, I discovered a number of pretty
> serious bugs in how we handle various cases in tcp_tap_handler() and
> tcp_data_from_tap(). This series fixes a number of them.
>
> Note that while I'm pretty sure the bugs fixed here are real, I
> haven't yet positively traced how they lead to the symptoms in bug 68
> - I'm still waiting on the results from some special instrumentation
> to track that down.
>
> Link: https://bugs.passt.top/show_bug.cgi?id=68
>
> David Gibson (8):
> tcp, tap: Correctly advance through packets in tcp_tap_handler()
> udp, tap: Correctly advance through packets in udp_tap_handler()
> tcp: Remove some redundant packet_get() operations
> tcp: Never hash match closed connections
> tcp: Return consumed packet count from tcp_data_from_tap()
> tcp: Correctly handle RST followed rapidly by SYN
> tcp: Consolidate paths where we initiate reset on tap interface
> tcp: Correct handling of FIN,ACK followed by SYN
Series applied, thanks.
--
Stefano
prev parent reply other threads:[~2023-09-08 15:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-08 1:49 [PATCH 0/8] Fix a number of bugs with handling of TCP packets from tap David Gibson
2023-09-08 1:49 ` [PATCH 1/8] tcp, tap: Correctly advance through packets in tcp_tap_handler() David Gibson
2023-09-08 1:49 ` [PATCH 2/8] udp, tap: Correctly advance through packets in udp_tap_handler() David Gibson
2023-09-08 1:49 ` [PATCH 3/8] tcp: Remove some redundant packet_get() operations David Gibson
2023-09-08 1:49 ` [PATCH 4/8] tcp: Never hash match closed connections David Gibson
2023-09-08 1:49 ` [PATCH 5/8] tcp: Return consumed packet count from tcp_data_from_tap() David Gibson
2023-09-08 1:49 ` [PATCH 6/8] tcp: Correctly handle RST followed rapidly by SYN David Gibson
2023-09-08 1:49 ` [PATCH 7/8] tcp: Consolidate paths where we initiate reset on tap interface David Gibson
2023-09-08 1:49 ` [PATCH 8/8] tcp: Correct handling of FIN,ACK followed by SYN David Gibson
2023-09-08 15:27 ` Stefano Brivio [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230908172647.1b081e80@elisabeth \
--to=sbrivio@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=jlesev@gmail.com \
--cc=passt-dev@passt.top \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).