From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTP id DC7BB5A026D for ; Fri, 8 Sep 2023 17:27:09 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1694186828; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1+/vXRwIqDhtQ4Gg27850jhQwDOvxDCfv/OsDS9cnl0=; b=E77meILCQR1KSHq2neCnDdtY3KeGf18LMkOQa9diSLKcR1Dig67aJg6zHrGteplceVFQxi +FHOXMKfjtFjPI4qzgRWPEFKMkP+b9ihJ2S0NMyKUNhNj1IHj3MTKWksMWenLYbRSghMTS Nw64KJtuJ+rnaJxZJmDRaCIkbp6Ptvw= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-130-pty0xNXkMI-ByCPHcdtsJQ-1; Fri, 08 Sep 2023 11:27:05 -0400 X-MC-Unique: pty0xNXkMI-ByCPHcdtsJQ-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id AAFB73C11A0C; Fri, 8 Sep 2023 15:27:04 +0000 (UTC) Received: from elisabeth (unknown [10.39.208.34]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D926F63F67; Fri, 8 Sep 2023 15:27:03 +0000 (UTC) Date: Fri, 8 Sep 2023 17:27:01 +0200 From: Stefano Brivio To: David Gibson Subject: Re: [PATCH 0/8] Fix a number of bugs with handling of TCP packets from tap Message-ID: <20230908172647.1b081e80@elisabeth> In-Reply-To: <20230908014953.822952-1-david@gibson.dropbear.id.au> References: <20230908014953.822952-1-david@gibson.dropbear.id.au> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: OSUI4OCEQGICD54PLVY7FA4NGZCUFOQI X-Message-ID-Hash: OSUI4OCEQGICD54PLVY7FA4NGZCUFOQI X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, jlesev@gmail.com X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri, 8 Sep 2023 11:49:45 +1000 David Gibson wrote: > In the course of investigating bug 68, I discovered a number of pretty > serious bugs in how we handle various cases in tcp_tap_handler() and > tcp_data_from_tap(). This series fixes a number of them. > > Note that while I'm pretty sure the bugs fixed here are real, I > haven't yet positively traced how they lead to the symptoms in bug 68 > - I'm still waiting on the results from some special instrumentation > to track that down. > > Link: https://bugs.passt.top/show_bug.cgi?id=68 > > David Gibson (8): > tcp, tap: Correctly advance through packets in tcp_tap_handler() > udp, tap: Correctly advance through packets in udp_tap_handler() > tcp: Remove some redundant packet_get() operations > tcp: Never hash match closed connections > tcp: Return consumed packet count from tcp_data_from_tap() > tcp: Correctly handle RST followed rapidly by SYN > tcp: Consolidate paths where we initiate reset on tap interface > tcp: Correct handling of FIN,ACK followed by SYN Series applied, thanks. -- Stefano