From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from gandalf.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by passt.top (Postfix) with ESMTPS id 609045A026F for ; Fri, 15 Sep 2023 08:43:45 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=201602; t=1694760219; bh=/5UwtWpNQkDQtXzyE1xJB89uiDlQfk72zwREc7ZDgKE=; h=From:To:Cc:Subject:Date:From; b=HdMZqNM3VZiOdQCb1ikQZg5mZ3LpWGAg2lJZGRtXj9CF0kgKSwnrF+3QfhigBttKh S0RP5zYzz/xYyU0COZS98wqsWNS387oZdzrT2sgogEcxmK0ihazqKZbvNj+9NjTG2w OqZRUB4drXf1+uM/s8U6ZhIYQnyfELrf688UIfvE= Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4Rn4Qg4MpPz4x5K; Fri, 15 Sep 2023 16:43:39 +1000 (AEST) From: David Gibson To: passt-dev@passt.top, Stefano Brivio Subject: [PATCH 0/2] Some static checker fixes Date: Fri, 15 Sep 2023 16:43:35 +1000 Message-ID: <20230915064337.2380211-1-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.41.0 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Message-ID-Hash: SZSHSSCQBJNWWSPHLLAWAY7YU3NEQJVE X-Message-ID-Hash: SZSHSSCQBJNWWSPHLLAWAY7YU3NEQJVE X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: David Gibson X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: We already had a couple of places we were working around clang-tidy issue 58992, and the flow table series adds more. I got sick of ugly inlines every time we used a syscall which returns a socket address, so wrote a patch to consolidate the workarounds in one place. However, that patch added an include of to util.h which exposed a classic C library gotcha in packet.c, so I fixed that too. David Gibson (2): packet: Avoid shadowing index(3) util: Consolidate and improve workarounds for clang-tidy issue 58992 Makefile | 2 +- icmp.c | 5 ----- packet.c | 28 ++++++++++++++-------------- packet.h | 10 +++++----- tcp.c | 8 +------- util.h | 41 +++++++++++++++++++++++++++++++++++++++++ 6 files changed, 62 insertions(+), 32 deletions(-) -- 2.41.0