public inbox for passt-dev@passt.top
 help / color / mirror / code / Atom feed
From: Stefano Brivio <sbrivio@redhat.com>
To: Nikolay Edigaryev <edigaryev@gmail.com>
Cc: David Gibson <david@gibson.dropbear.id.au>, passt-dev@passt.top
Subject: Re: [PATCH] arp: only send ARP replies for --gateway address
Date: Mon, 18 Sep 2023 16:01:34 +0200	[thread overview]
Message-ID: <20230918160134.09d2b706@elisabeth> (raw)
In-Reply-To: <ZQe1O6CqIqQWmcaM@zatzit>

On Mon, 18 Sep 2023 12:26:03 +1000
David Gibson <david@gibson.dropbear.id.au> wrote:

> On Fri, Sep 15, 2023 at 06:20:45PM +0400, Nikolay Edigaryev wrote:
> > Problem: when passt/pasta are working in a broadcast domain with more
> > than one host machine,  
> 
> Oof.  So, at present, passt/pasta is really not designed to have more
> than a single machine on the "tap" side.  Changing the ARP behaviour
> is likely to be the least of the problems with that setup.

Now I'm confused on which "side" this happens. :) Nikolay, can you
articulate the issue a bit better? Do you really have multiple *host*
machines? Does the passt process... move between them?

By the way, the only concern I have with this change is that the guest
might ignore the gateway address it's being assigned, for whatever
reason, and by just resolving "almost everything" we guarantee the
traffic goes out anyway.

If there's no other way to solve the issue you're facing, I would
rather propose to have this as an option, and perhaps have it off by
default.

-- 
Stefano


  reply	other threads:[~2023-09-18 14:01 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-15 14:20 [PATCH] arp: only send ARP replies for --gateway address Nikolay Edigaryev
2023-09-18  2:26 ` David Gibson
2023-09-18 14:01   ` Stefano Brivio [this message]
2023-09-18 15:52     ` Nikolay Edigaryev
2023-09-19  2:09       ` David Gibson
2023-10-12  4:35         ` David Gibson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230918160134.09d2b706@elisabeth \
    --to=sbrivio@redhat.com \
    --cc=david@gibson.dropbear.id.au \
    --cc=edigaryev@gmail.com \
    --cc=passt-dev@passt.top \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://passt.top/passt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).