From: David Gibson <david@gibson.dropbear.id.au>
To: passt-dev@passt.top, Stefano Brivio <sbrivio@redhat.com>
Cc: David Gibson <david@gibson.dropbear.id.au>
Subject: [PATCH v2 0/2] Some static checker fixes
Date: Thu, 21 Sep 2023 14:49:37 +1000 [thread overview]
Message-ID: <20230921044939.1752225-1-david@gibson.dropbear.id.au> (raw)
We already had a couple of places we were working around clang-tidy
issue 58992, and the flow table series adds more. I got sick of ugly
inlines every time we used a syscall which returns a socket address,
so wrote a patch to consolidate the workarounds in one place.
However, that patch added an include of <string.h> to util.h which
exposed a classic C library gotcha in packet.c, so I fixed that too.
Changes since v1:
* Updated missed comment to match code changes in 1/2
* Fixed more places which shadowed index(3)
David Gibson (2):
Avoid shadowing index(3)
util: Consolidate and improve workarounds for clang-tidy issue 58992
Makefile | 2 +-
icmp.c | 5 -----
packet.c | 30 +++++++++++++++---------------
packet.h | 10 +++++-----
tcp.c | 22 ++++++++--------------
tcp_splice.c | 2 +-
util.c | 12 ++++++------
util.h | 43 ++++++++++++++++++++++++++++++++++++++++++-
8 files changed, 78 insertions(+), 48 deletions(-)
--
2.41.0
next reply other threads:[~2023-09-21 4:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-21 4:49 David Gibson [this message]
2023-09-21 4:49 ` [PATCH v2 1/2] Avoid shadowing index(3) David Gibson
2023-09-21 4:49 ` [PATCH v2 2/2] util: Consolidate and improve workarounds for clang-tidy issue 58992 David Gibson
2023-09-27 17:04 ` [PATCH v2 0/2] Some static checker fixes Stefano Brivio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230921044939.1752225-1-david@gibson.dropbear.id.au \
--to=david@gibson.dropbear.id.au \
--cc=passt-dev@passt.top \
--cc=sbrivio@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).