From: David Gibson <david@gibson.dropbear.id.au>
To: Stefano Brivio <sbrivio@redhat.com>, passt-dev@passt.top
Cc: David Gibson <david@gibson.dropbear.id.au>
Subject: [PATCH 00/10] siphash: cleanups and fixes
Date: Sat, 23 Sep 2023 00:06:20 +1000 [thread overview]
Message-ID: <20230922140630.3184256-1-david@gibson.dropbear.id.au> (raw)
While working on unifying the hashing for the flow table, I noticed
some awkwardness in the siphash functions. While looking into that I
noticed some bugs. So.. here we are.
David Gibson (10):
siphash: Make siphash functions consistently return 64-bit results
siphash: Make sip round calculations an inline function rather than
macro
siphash: Add siphash_feed() helper
siphash: Clean up hash finalisation with posthash_final() function
siphash: Fix bug in state initialisation
siphash: Use more hygienic state initialiser
siphash: Use specific structure for internal state
siphash: Make internal helpers public
siphash, checksum: Move TBAA explanation to checksum.c
siphash: Use incremental rather than all-at-once siphash functions
Makefile | 2 +-
checksum.c | 19 ++--
inany.h | 16 +++-
siphash.c | 243 ---------------------------------------------------
siphash.h | 119 +++++++++++++++++++++++--
tcp.c | 37 +++-----
tcp_splice.c | 1 +
7 files changed, 158 insertions(+), 279 deletions(-)
delete mode 100644 siphash.c
--
2.41.0
next reply other threads:[~2023-09-22 14:06 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-22 14:06 David Gibson [this message]
2023-09-22 14:06 ` [PATCH 01/10] siphash: Make siphash functions consistently return 64-bit results David Gibson
2023-09-22 14:06 ` [PATCH 02/10] siphash: Make sip round calculations an inline function rather than macro David Gibson
2023-09-22 14:06 ` [PATCH 03/10] siphash: Add siphash_feed() helper David Gibson
2023-09-22 14:06 ` [PATCH 04/10] siphash: Clean up hash finalisation with posthash_final() function David Gibson
2023-09-22 14:06 ` [PATCH 05/10] siphash: Fix bug in state initialisation David Gibson
2023-09-22 14:06 ` [PATCH 06/10] siphash: Use more hygienic state initialiser David Gibson
2023-09-27 17:04 ` Stefano Brivio
2023-09-28 1:20 ` David Gibson
2023-09-29 15:19 ` Stefano Brivio
2023-09-22 14:06 ` [PATCH 07/10] siphash: Use specific structure for internal state David Gibson
2023-09-22 14:06 ` [PATCH 08/10] siphash: Make internal helpers public David Gibson
2023-09-22 14:06 ` [PATCH 09/10] siphash, checksum: Move TBAA explanation to checksum.c David Gibson
2023-09-22 14:06 ` [PATCH 10/10] siphash: Use incremental rather than all-at-once siphash functions David Gibson
2023-09-26 6:23 ` David Gibson
2023-09-26 7:02 ` David Gibson
2023-09-27 17:05 ` Stefano Brivio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230922140630.3184256-1-david@gibson.dropbear.id.au \
--to=david@gibson.dropbear.id.au \
--cc=passt-dev@passt.top \
--cc=sbrivio@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).