From mboxrd@z Thu Jan 1 00:00:00 1970
Received: by passt.top (Postfix, from userid 1000)
id 9FABE5A0272; Sat, 23 Sep 2023 00:06:10 +0200 (CEST)
From: Stefano Brivio <sbrivio@redhat.com>
To: David Gibson <david@gibson.dropbear.id.au>,
Matej Hrica <mhrica@redhat.com>
Subject: [PATCH RFT 1/5] tcp: Fix comment to tcp_sock_consume()
Date: Sat, 23 Sep 2023 00:06:06 +0200
Message-Id: <20230922220610.58767-2-sbrivio@redhat.com>
X-Mailer: git-send-email 2.39.2
In-Reply-To: <20230922220610.58767-1-sbrivio@redhat.com>
References: <20230922220610.58767-1-sbrivio@redhat.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Message-ID-Hash: 5F5XS4WI76OBKQQ2KN32HCOVU6BMZBX3
X-Message-ID-Hash: 5F5XS4WI76OBKQQ2KN32HCOVU6BMZBX3
X-MailFrom: sbrivio@passt.top
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header
CC: passt-dev@passt.top
X-Mailman-Version: 3.3.8
Precedence: list
List-Id: Development discussion and patches for passt <passt-dev.passt.top>
Archived-At: <https://archives.passt.top/passt-dev/20230922220610.58767-2-sbrivio@redhat.com/>
Archived-At: <https://passt.top/hyperkitty/list/passt-dev@passt.top/message/5F5XS4WI76OBKQQ2KN32HCOVU6BMZBX3/>
List-Archive: <https://archives.passt.top/passt-dev/>
List-Archive: <https://passt.top/hyperkitty/list/passt-dev@passt.top/>
List-Help: <mailto:passt-dev-request@passt.top?subject=help>
List-Owner: <mailto:passt-dev-owner@passt.top>
List-Post: <mailto:passt-dev@passt.top>
List-Subscribe: <mailto:passt-dev-join@passt.top>
List-Unsubscribe: <mailto:passt-dev-leave@passt.top>
Note that tcp_sock_consume() doesn't update ACK sequence counters
anymore.
Fixes: cc6d8286d104 ("tcp: Reset ACK_FROM_TAP_DUE flag only as needed, update timer")
Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
---
tcp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tcp.c b/tcp.c
index dd3142d..aa1c8c9 100644
--- a/tcp.c
+++ b/tcp.c
@@ -2103,7 +2103,7 @@ static void tcp_conn_from_tap(struct ctx *c,
}
/**
- * tcp_sock_consume() - Consume (discard) data from buffer, update ACK sequence
+ * tcp_sock_consume() - Consume (discard) data from buffer
* @conn: Connection pointer
* @ack_seq: ACK sequence, host order
*
--
2.39.2