From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTP id BBD385A026F for ; Wed, 27 Sep 2023 19:04:33 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1695834272; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=198i8snMn4QGW3rmAc3ZWgmwzny4YsLTeoOF0yMq0/0=; b=hM8TMo5ZwcKB9ZfYmn9lIa8UgceJ4zxEYdoTX/+WwhuOABX+YoDZsnmcCr+1I4o+wBhIVf zEOEVPzd2H/Z/Ql5H912dSRfLf6XB6p0y7LuQlilygndB7H2UOy4zKKwcKom0nzPx1J0kx JD3+sNY+bG/ZrV7nTq9ifCX94MXtZgM= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-692-hkwUGEghOYW5xGc-tpOFUw-1; Wed, 27 Sep 2023 13:04:29 -0400 X-MC-Unique: hkwUGEghOYW5xGc-tpOFUw-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id DD486101A53B; Wed, 27 Sep 2023 17:04:28 +0000 (UTC) Received: from elisabeth (unknown [10.39.208.37]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 180652156702; Wed, 27 Sep 2023 17:04:27 +0000 (UTC) Date: Wed, 27 Sep 2023 19:04:18 +0200 From: Stefano Brivio To: David Gibson Subject: Re: [PATCH v2 0/2] Some static checker fixes Message-ID: <20230927190418.2be49609@elisabeth> In-Reply-To: <20230921044939.1752225-1-david@gibson.dropbear.id.au> References: <20230921044939.1752225-1-david@gibson.dropbear.id.au> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: IZRAJQ33UFFFYUIL4IOIUKRWREUGDHMQ X-Message-ID-Hash: IZRAJQ33UFFFYUIL4IOIUKRWREUGDHMQ X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Thu, 21 Sep 2023 14:49:37 +1000 David Gibson wrote: > We already had a couple of places we were working around clang-tidy > issue 58992, and the flow table series adds more. I got sick of ugly > inlines every time we used a syscall which returns a socket address, > so wrote a patch to consolidate the workarounds in one place. > > However, that patch added an include of to util.h which > exposed a classic C library gotcha in packet.c, so I fixed that too. Applied, sorry for the delay. -- Stefano