From: Stefano Brivio <sbrivio@redhat.com>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: passt-dev@passt.top
Subject: Re: [PATCH v2 00/10] siphash: cleanups and fixes
Date: Sat, 30 Sep 2023 12:43:55 +0200 [thread overview]
Message-ID: <20230930124312.6c279f88@elisabeth> (raw)
In-Reply-To: <20230928012102.1446180-1-david@gibson.dropbear.id.au>
On Thu, 28 Sep 2023 11:20:52 +1000
David Gibson <david@gibson.dropbear.id.au> wrote:
> While working on unifying the hashing for the flow table, I noticed
> some awkwardness in the siphash functions. While looking into that I
> noticed some bugs. So.. here we are.
>
> Changes since v1:
> * Don't accidentally increase the alignment of union inany_addr
>
> David Gibson (10):
> siphash: Make siphash functions consistently return 64-bit results
> siphash: Make sip round calculations an inline function rather than
> macro
> siphash: Add siphash_feed() helper
> siphash: Clean up hash finalisation with posthash_final() function
> siphash: Fix bug in state initialisation
> siphash: Use more hygienic state initialiser
> siphash: Use specific structure for internal state
> siphash: Make internal helpers public
> siphash, checksum: Move TBAA explanation to checksum.c
> siphash: Use incremental rather than all-at-once siphash functions
Applied, thanks.
--
Stefano
prev parent reply other threads:[~2023-09-30 10:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-28 1:20 [PATCH v2 00/10] siphash: cleanups and fixes David Gibson
2023-09-28 1:20 ` [PATCH v2 01/10] siphash: Make siphash functions consistently return 64-bit results David Gibson
2023-09-28 1:20 ` [PATCH v2 02/10] siphash: Make sip round calculations an inline function rather than macro David Gibson
2023-09-28 1:20 ` [PATCH v2 03/10] siphash: Add siphash_feed() helper David Gibson
2023-09-28 1:20 ` [PATCH v2 04/10] siphash: Clean up hash finalisation with posthash_final() function David Gibson
2023-09-28 1:20 ` [PATCH v2 05/10] siphash: Fix bug in state initialisation David Gibson
2023-09-28 1:20 ` [PATCH v2 06/10] siphash: Use more hygienic state initialiser David Gibson
2023-09-28 1:20 ` [PATCH v2 07/10] siphash: Use specific structure for internal state David Gibson
2023-09-28 1:21 ` [PATCH v2 08/10] siphash: Make internal helpers public David Gibson
2023-09-28 1:21 ` [PATCH v2 09/10] siphash, checksum: Move TBAA explanation to checksum.c David Gibson
2023-09-28 1:21 ` [PATCH v2 10/10] siphash: Use incremental rather than all-at-once siphash functions David Gibson
2023-09-30 10:43 ` Stefano Brivio [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230930124312.6c279f88@elisabeth \
--to=sbrivio@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=passt-dev@passt.top \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).