From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTP id 4C1435A026D for ; Sat, 30 Sep 2023 12:45:03 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1696070702; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dxPlbyIWr03DLU/O5QAazHCyTM1DTUfjmcAQgrcnNVo=; b=agydPEuLYCfUBuGOzt3mPTrMv1ouO3ScPJ+8XUUQmAIqZyvQJYFZF9pcPGKpzjM1tKoMFn ptIuyYVNe6HTa4bPf8U323o3Gxqo4A1Xp6p7/GcDZHAKBmIu8o+v4E21WBgiAGiVJP7ckI Lcv48tAUXD08+5n2f6AKRXTpqR2Ec+M= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-27-9q8tkHlJPRWZDH_hHypbwA-1; Sat, 30 Sep 2023 06:45:00 -0400 X-MC-Unique: 9q8tkHlJPRWZDH_hHypbwA-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id B3BEA800969; Sat, 30 Sep 2023 10:44:59 +0000 (UTC) Received: from elisabeth (unknown [10.39.208.2]) by smtp.corp.redhat.com (Postfix) with ESMTPS id CB718C15BB8; Sat, 30 Sep 2023 10:44:58 +0000 (UTC) Date: Sat, 30 Sep 2023 12:43:55 +0200 From: Stefano Brivio To: David Gibson Subject: Re: [PATCH v2 00/10] siphash: cleanups and fixes Message-ID: <20230930124312.6c279f88@elisabeth> In-Reply-To: <20230928012102.1446180-1-david@gibson.dropbear.id.au> References: <20230928012102.1446180-1-david@gibson.dropbear.id.au> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: ZS2NIZAZNQ6CW27B36CDBHQXYTGESCQB X-Message-ID-Hash: ZS2NIZAZNQ6CW27B36CDBHQXYTGESCQB X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Thu, 28 Sep 2023 11:20:52 +1000 David Gibson wrote: > While working on unifying the hashing for the flow table, I noticed > some awkwardness in the siphash functions. While looking into that I > noticed some bugs. So.. here we are. > > Changes since v1: > * Don't accidentally increase the alignment of union inany_addr > > David Gibson (10): > siphash: Make siphash functions consistently return 64-bit results > siphash: Make sip round calculations an inline function rather than > macro > siphash: Add siphash_feed() helper > siphash: Clean up hash finalisation with posthash_final() function > siphash: Fix bug in state initialisation > siphash: Use more hygienic state initialiser > siphash: Use specific structure for internal state > siphash: Make internal helpers public > siphash, checksum: Move TBAA explanation to checksum.c > siphash: Use incremental rather than all-at-once siphash functions Applied, thanks. -- Stefano