From: David Gibson <david@gibson.dropbear.id.au>
To: passt-dev@passt.top, Stefano Brivio <sbrivio@redhat.com>
Cc: David Gibson <david@gibson.dropbear.id.au>
Subject: [PATCH 6/8] test/perf: "MTU" changes in passt_tcp host to guest aren't useful
Date: Mon, 6 Nov 2023 18:08:31 +1100 [thread overview]
Message-ID: <20231106070834.1270986-7-david@gibson.dropbear.id.au> (raw)
In-Reply-To: <20231106070834.1270986-1-david@gibson.dropbear.id.au>
The TCP packet size used on the passt L2 link (qemu socket) makes a huge
difference to passt/pasta throughput; many of passt's overheads (chiefly
syscalls) are per-packet.
That packet size is largely determined by the MTU on the L2 link, so we
benchmark for a number of different MTUs. That works well for the guest to
host transfers. For the host to guest transfers, we purport to test for
different MTUs, but we're not actually adjusting anything interesting.
The host to guest transfers adjust the MTU on the "host's" (actually ns)
loopback interface. However, that only affects the packet size for the
socket going to passt, not the packet size for the L2 link that passt
manages - passt can and will repack the stream into packets of its own
size. Since the depacketization on that socket is handled by the kernel it
doesn't have a lot of bearing on passt's performance.
We can't fix this by changing the L2 link MTU from the guest side (as we do
for guest to host), because that would only change the guest's view of the
MTU, passt would still think it has the large MTU. We could test this by
using the --mtu option to passt, but that would require restarting passt
for each run, which is awkward in the current setup. So, for now, drop all
the "small MTU" tests for host to guest.
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
---
test/perf/passt_tcp | 37 ++++++++-----------------------------
1 file changed, 8 insertions(+), 29 deletions(-)
diff --git a/test/perf/passt_tcp b/test/perf/passt_tcp
index 9363922..205b9af 100644
--- a/test/perf/passt_tcp
+++ b/test/perf/passt_tcp
@@ -138,19 +138,11 @@ iperf3s guest 100${i}1 __THREADS__
bw -
bw -
-ns ip link set dev lo mtu 1280
-iperf3 BW ns ::1 100${i}1 __THREADS__ __TIME__ __OPTS__
-bw __BW__ 1.0 1.2
-ns ip link set dev lo mtu 1500
-iperf3 BW ns ::1 100${i}1 __THREADS__ __TIME__ __OPTS__
-bw __BW__ 2.0 3.0
-ns ip link set dev lo mtu 9000
-iperf3 BW ns ::1 100${i}1 __THREADS__ __TIME__ __OPTS__
-bw __BW__ 5.0 6.0
-ns ip link set dev lo mtu 65520
+bw -
+bw -
+bw -
iperf3 BW ns ::1 100${i}1 __THREADS__ __TIME__ __OPTS__
bw __BW__ 6.0 6.8
-ns ip link set dev lo mtu 65535
iperf3k guest
@@ -180,26 +172,13 @@ lat __LAT__ 500 350
tr TCP throughput over IPv4: host to guest
iperf3s guest 100${i}1 __THREADS__
-ns ip link set dev lo mtu 256
-iperf3 BW ns 127.0.0.1 100${i}1 __THREADS__ __TIME__ __OPTS__
-bw __BW__ 0.3 0.5
-ns ip link set dev lo mtu 576
-iperf3 BW ns 127.0.0.1 100${i}1 __THREADS__ __TIME__ __OPTS__
-bw __BW__ 0.5 1.0
-ns ip link set dev lo mtu 1280
-ns ip addr add ::1 dev lo
-iperf3 BW ns 127.0.0.1 100${i}1 __THREADS__ __TIME__ __OPTS__
-bw __BW__ 2.0 3.0
-ns ip link set dev lo mtu 1500
-iperf3 BW ns 127.0.0.1 100${i}1 __THREADS__ __TIME__ __OPTS__
-bw __BW__ 2.0 3.0
-ns ip link set dev lo mtu 9000
-iperf3 BW ns 127.0.0.1 100${i}1 __THREADS__ __TIME__ __OPTS__
-bw __BW__ 5.0 6.0
-ns ip link set dev lo mtu 65520
+bw -
+bw -
+bw -
+bw -
+bw -
iperf3 BW ns 127.0.0.1 100${i}1 __THREADS__ __TIME__ __OPTS__
bw __BW__ 6.0 6.8
-ns ip link set dev lo mtu 65535
iperf3k guest
--
@@ -138,19 +138,11 @@ iperf3s guest 100${i}1 __THREADS__
bw -
bw -
-ns ip link set dev lo mtu 1280
-iperf3 BW ns ::1 100${i}1 __THREADS__ __TIME__ __OPTS__
-bw __BW__ 1.0 1.2
-ns ip link set dev lo mtu 1500
-iperf3 BW ns ::1 100${i}1 __THREADS__ __TIME__ __OPTS__
-bw __BW__ 2.0 3.0
-ns ip link set dev lo mtu 9000
-iperf3 BW ns ::1 100${i}1 __THREADS__ __TIME__ __OPTS__
-bw __BW__ 5.0 6.0
-ns ip link set dev lo mtu 65520
+bw -
+bw -
+bw -
iperf3 BW ns ::1 100${i}1 __THREADS__ __TIME__ __OPTS__
bw __BW__ 6.0 6.8
-ns ip link set dev lo mtu 65535
iperf3k guest
@@ -180,26 +172,13 @@ lat __LAT__ 500 350
tr TCP throughput over IPv4: host to guest
iperf3s guest 100${i}1 __THREADS__
-ns ip link set dev lo mtu 256
-iperf3 BW ns 127.0.0.1 100${i}1 __THREADS__ __TIME__ __OPTS__
-bw __BW__ 0.3 0.5
-ns ip link set dev lo mtu 576
-iperf3 BW ns 127.0.0.1 100${i}1 __THREADS__ __TIME__ __OPTS__
-bw __BW__ 0.5 1.0
-ns ip link set dev lo mtu 1280
-ns ip addr add ::1 dev lo
-iperf3 BW ns 127.0.0.1 100${i}1 __THREADS__ __TIME__ __OPTS__
-bw __BW__ 2.0 3.0
-ns ip link set dev lo mtu 1500
-iperf3 BW ns 127.0.0.1 100${i}1 __THREADS__ __TIME__ __OPTS__
-bw __BW__ 2.0 3.0
-ns ip link set dev lo mtu 9000
-iperf3 BW ns 127.0.0.1 100${i}1 __THREADS__ __TIME__ __OPTS__
-bw __BW__ 5.0 6.0
-ns ip link set dev lo mtu 65520
+bw -
+bw -
+bw -
+bw -
+bw -
iperf3 BW ns 127.0.0.1 100${i}1 __THREADS__ __TIME__ __OPTS__
bw __BW__ 6.0 6.8
-ns ip link set dev lo mtu 65535
iperf3k guest
--
2.41.0
next prev parent reply other threads:[~2023-11-06 7:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-06 7:08 [PATCH 0/8] Clean ups and speed ups to benchmarks David Gibson
2023-11-06 7:08 ` [PATCH 1/8] test/perf: Remove stale iperf3c/iperf3s directives David Gibson
2023-11-06 7:08 ` [PATCH 2/8] test/perf: Get iperf3 stats from client side David Gibson
2023-11-06 7:08 ` [PATCH 3/8] test/perf: Start iperf3 server less often David Gibson
2023-11-06 7:08 ` [PATCH 4/8] test/perf: Small MTUs for spliced TCP aren't interesting David Gibson
2023-11-06 7:08 ` [PATCH 5/8] test/perf: Explicitly control UDP packet length, instead of MTU David Gibson
2023-11-06 7:08 ` David Gibson [this message]
2023-11-06 7:08 ` [PATCH 7/8] test/perf: Remove unnecessary --pacing-timer options David Gibson
2023-11-06 7:08 ` [PATCH 8/8] test/perf: Simplify calculation of "omit" time for TCP throughput David Gibson
2023-11-07 12:45 ` [PATCH 0/8] Clean ups and speed ups to benchmarks Stefano Brivio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231106070834.1270986-7-david@gibson.dropbear.id.au \
--to=david@gibson.dropbear.id.au \
--cc=passt-dev@passt.top \
--cc=sbrivio@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).