From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTP id 6FE555A026D for ; Tue, 7 Nov 2023 13:45:25 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1699361124; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sDfHVMSFgIKI0sAxPHGT7UatkPuARvClc0t9n1ytVjg=; b=IhEXdsT2XvtZ8Zx9uzsRZ6vUpd2zgNWCGUDipf3z8vVfMeiZWNS5gpPaeRvUqtfXENKunM nbalRUZ+BdLZhYwp/SErQi9xYpWvfIcVpKdsbTc4YnInOrDRSKwtVh3pMGRcNO+YjyLcHE aPZ4lbFlV8Okkum6SqXFU/SfCcjJRfQ= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-57-oOEgI5B2NtWURqFyLiuUfg-1; Tue, 07 Nov 2023 07:45:21 -0500 X-MC-Unique: oOEgI5B2NtWURqFyLiuUfg-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 31924811E86; Tue, 7 Nov 2023 12:45:21 +0000 (UTC) Received: from elisabeth (unknown [10.39.208.12]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5CD632026D66; Tue, 7 Nov 2023 12:45:20 +0000 (UTC) Date: Tue, 7 Nov 2023 13:45:18 +0100 From: Stefano Brivio To: David Gibson Subject: Re: [PATCH v2 00/11] tcp_splice: Better exploit symmetry between sides of connection Message-ID: <20231107134518.0eb3a131@elisabeth> In-Reply-To: <20231107024250.2290959-1-david@gibson.dropbear.id.au> References: <20231107024250.2290959-1-david@gibson.dropbear.id.au> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: XLJJQF3MHEADBEBVLNXNM4H6AMGXYZUQ X-Message-ID-Hash: XLJJQF3MHEADBEBVLNXNM4H6AMGXYZUQ X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Tue, 7 Nov 2023 13:42:39 +1100 David Gibson wrote: > For spliced connections, both "sides" are sockets, and for many > purposes how we deal with each side is symmetric. Currently, however, > we track the information for each side in independent fields in the > structure, meaning we can't easily exploit that symmetry. > > This makes a number of reorganizations of the tcp splice code so that > we can explot that symmetry to reduce code size. This will have some > additional advantages when we come to integrate with the in-progress > unified flow table. > > Based on top of the interface identifiers and automatic forwarding > cleanup series. > > Changes since v1: > * Small updates to comments and commit messages > > David Gibson (11): > tcp_splice: Remove redundant tcp_splice_epoll_ctl() > tcp_splice: Correct error handling in tcp_splice_epoll_ctl() > tcp_splice: Don't handle EPOLL_CTL_DEL as part of > tcp_splice_epoll_ctl() > tcp_splice: Remove unnecessary forward declaration > tcp_splice: Avoid awkward temporaries in tcp_splice_epoll_ctl() > tcp_splice: Don't pool pipes in pairs > tcp_splice: Rename sides of connection from a/b to 0/1 > tcp_splice: Exploit side symmetry in tcp_splice_timer() > tcp_splice: Exploit side symmetry in tcp_splice_connect_finish() > tcp_splice: Exploit side symmetry in tcp_splice_destroy() > tcp_splice: Simplify selection of socket and pipe sides in socket > handler Applied. -- Stefano