From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from gandalf.ozlabs.org (gandalf.ozlabs.org [150.107.74.76])
	by passt.top (Postfix) with ESMTPS id DBD175A026D
	for <passt-dev@passt.top>; Thu,  9 Nov 2023 10:54:11 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
	d=gibson.dropbear.id.au; s=201602; t=1699523645;
	bh=B2Xrt8GruOZa770/p1Ofu0ac2fa9UiSKho/D8frh/kI=;
	h=From:To:Cc:Subject:Date:From;
	b=fS/6fiUEnd0z1mHgmbrrOz2i6c8I6N6kn9sbCrI8wEjZxQxKiNx2D/iJU/KjayV5T
	 rWJfG2WdCBAcqzqe2Ylkbj5aVlcMv3Wr58PbzyNcvj5zcSJKuatkJbLn7dHiyUTZbt
	 tr3UVvmgWk6+cUr2L0jLFJNzK40fy8k7DHmlvurQ=
Received: by gandalf.ozlabs.org (Postfix, from userid 1007)
	id 4SQy316xfwz4xZk; Thu,  9 Nov 2023 20:54:05 +1100 (AEDT)
From: David Gibson <david@gibson.dropbear.id.au>
To: Stefano Brivio <sbrivio@redhat.com>,
	passt-dev@passt.top
Subject: [PATCH 0/2] Avoid bugs related to TCP_WINDOW_CLAMP
Date: Thu,  9 Nov 2023 20:53:58 +1100
Message-ID: <20231109095400.507679-1-david@gibson.dropbear.id.au>
X-Mailer: git-send-email 2.41.0
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Message-ID-Hash: DN6QQVU2N7UH4VTHSLI5NCJPKYIH6RDG
X-Message-ID-Hash: DN6QQVU2N7UH4VTHSLI5NCJPKYIH6RDG
X-MailFrom: dgibson@gandalf.ozlabs.org
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header
CC: David Gibson <david@gibson.dropbear.id.au>
X-Mailman-Version: 3.3.8
Precedence: list
List-Id: Development discussion and patches for passt <passt-dev.passt.top>
Archived-At: <https://archives.passt.top/passt-dev/20231109095400.507679-1-david@gibson.dropbear.id.au/>
Archived-At: <https://passt.top/hyperkitty/list/passt-dev@passt.top/message/DN6QQVU2N7UH4VTHSLI5NCJPKYIH6RDG/>
List-Archive: <https://archives.passt.top/passt-dev/>
List-Archive: <https://passt.top/hyperkitty/list/passt-dev@passt.top/>
List-Help: <mailto:passt-dev-request@passt.top?subject=help>
List-Owner: <mailto:passt-dev-owner@passt.top>
List-Post: <mailto:passt-dev@passt.top>
List-Subscribe: <mailto:passt-dev-join@passt.top>
List-Unsubscribe: <mailto:passt-dev-leave@passt.top>

The way we used TCP_WINDOW_CLAMP didn't really correspond to what it
actually did.  More recent kernels also have a nasty bug in the
handler which we could trigger, causing TCP stalls.

David Gibson (2):
  tcp: Rename and small cleanup to tcp_clamp_window()
  tcp: Don't use TCP_WINDOW_CLAMP

 tcp.c      | 70 +++++++++---------------------------------------------
 tcp_conn.h |  7 +++---
 2 files changed, 14 insertions(+), 63 deletions(-)

-- 
2.41.0