From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTP id 5F2485A026F for ; Fri, 10 Nov 2023 18:06:10 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1699635969; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QTgFv9d/lw3Xgu+OAlKlC6Y8KOc9YuwHATAasCd2qrg=; b=Bqe87+rQRmm+Zky+iLH5v08j9L9G7gq0dhI4WCkIHvPaI1MM8rF8w/2mfOBL+wjx9eFxqw Wn2S0nJmHE5e0ZjT+Sqsn4SNch2ROWbAnnlCX0nhnh1kdwPplXqxvLCIDB1wQ0FURLYPI1 tpfw6ioJoINIRVa8PtvgkeLAoJhGlho= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-98-N8_5PG3EPvKfV_Wwta6brA-1; Fri, 10 Nov 2023 12:06:07 -0500 X-MC-Unique: N8_5PG3EPvKfV_Wwta6brA-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 8987938157AB; Fri, 10 Nov 2023 17:06:07 +0000 (UTC) Received: from elisabeth (unknown [10.39.208.5]) by smtp.corp.redhat.com (Postfix) with ESMTPS id CB631C1596F; Fri, 10 Nov 2023 17:06:06 +0000 (UTC) Date: Fri, 10 Nov 2023 18:06:03 +0100 From: Stefano Brivio To: David Gibson Subject: Re: [PATCH 0/2] Avoid bugs related to TCP_WINDOW_CLAMP Message-ID: <20231110180603.0ef3be10@elisabeth> In-Reply-To: <20231109095400.507679-1-david@gibson.dropbear.id.au> References: <20231109095400.507679-1-david@gibson.dropbear.id.au> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.8 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: P64K7TMWPHJKORYPTPYXXHCCECMO3M7K X-Message-ID-Hash: P64K7TMWPHJKORYPTPYXXHCCECMO3M7K X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Thu, 9 Nov 2023 20:53:58 +1100 David Gibson wrote: > The way we used TCP_WINDOW_CLAMP didn't really correspond to what it > actually did. More recent kernels also have a nasty bug in the > handler which we could trigger, causing TCP stalls. > > David Gibson (2): > tcp: Rename and small cleanup to tcp_clamp_window() > tcp: Don't use TCP_WINDOW_CLAMP Applied. -- Stefano