From: Stefano Brivio <sbrivio@redhat.com>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: passt-dev@passt.top
Subject: Re: [PATCH] clang-tidy: Suppress silly misc-include-cleaner warnings
Date: Sun, 19 Nov 2023 21:08:03 +0100 [thread overview]
Message-ID: <20231119210803.398fa741@elisabeth> (raw)
In-Reply-To: <20231115025945.443578-1-david@gibson.dropbear.id.au>
On Wed, 15 Nov 2023 13:59:45 +1100
David Gibson <david@gibson.dropbear.id.au> wrote:
> clang-tidy from LLVM 17.0.3 (which is in Fedora 39) includes a new
> "misc-include-cleaner" warning that tries to make sure that headers
> *directly* provide the things that are used in the .c file. That sounds
> great in theory but is in practice unusable:
>
> Quite a few common things in the standard library are ultimately provided
> by OS-specific system headers, but for portability should be accessed via
> closer-to-standardised library headers. This will warn constantly about
> such cases: e.g. it will want you to include <linux/limits.h> instead of
> <limits.h> to get PATH_MAX.
>
> So, suppress this warning globally in the Makefile.
>
> Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Applied.
--
Stefano
prev parent reply other threads:[~2023-11-19 20:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-15 2:59 [PATCH] clang-tidy: Suppress silly misc-include-cleaner warnings David Gibson
2023-11-19 20:08 ` Stefano Brivio [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231119210803.398fa741@elisabeth \
--to=sbrivio@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=passt-dev@passt.top \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).