From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTP id 9FEC65A026D for ; Sun, 19 Nov 2023 21:08:12 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1700424491; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uDldy9sKOXbdM4jG/kid+HmDxz2/ZrL4dgevl5h0SlU=; b=Vy7XsXo4uw0x2z1FHsFrHFCqJ9rhrwRAd4uE93e0bZotCc33R9Acb5nH9zVU3CybipBhBA +HniA0jnR10hdL1S97lVoUFzv7BYgEYvurOfkmwr0/p/1V1n0FZZaXZQaIa0HOndhCCPxI BK7+2Oj7rydMV0tnqDKJJUhP1Kc8ytk= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-286-3Zx0if1EODuljtYP11QYFg-1; Sun, 19 Nov 2023 15:08:09 -0500 X-MC-Unique: 3Zx0if1EODuljtYP11QYFg-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 75B361C06509; Sun, 19 Nov 2023 20:08:09 +0000 (UTC) Received: from elisabeth (unknown [10.39.208.4]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 74E9110EA1; Sun, 19 Nov 2023 20:08:08 +0000 (UTC) Date: Sun, 19 Nov 2023 21:08:03 +0100 From: Stefano Brivio To: David Gibson Subject: Re: [PATCH] clang-tidy: Suppress silly misc-include-cleaner warnings Message-ID: <20231119210803.398fa741@elisabeth> In-Reply-To: <20231115025945.443578-1-david@gibson.dropbear.id.au> References: <20231115025945.443578-1-david@gibson.dropbear.id.au> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.5 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: NJ7DCEOBLWLCX7MCX7W3NUG32X6P37XC X-Message-ID-Hash: NJ7DCEOBLWLCX7MCX7W3NUG32X6P37XC X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed, 15 Nov 2023 13:59:45 +1100 David Gibson wrote: > clang-tidy from LLVM 17.0.3 (which is in Fedora 39) includes a new > "misc-include-cleaner" warning that tries to make sure that headers > *directly* provide the things that are used in the .c file. That sounds > great in theory but is in practice unusable: > > Quite a few common things in the standard library are ultimately provided > by OS-specific system headers, but for portability should be accessed via > closer-to-standardised library headers. This will warn constantly about > such cases: e.g. it will want you to include instead of > to get PATH_MAX. > > So, suppress this warning globally in the Makefile. > > Signed-off-by: David Gibson Applied. -- Stefano