Re: [PATCH 3/4] tcp, tcp_splice: CONN_IDX subtraction of pointers isn't always long

[Stefano Brivio <sbrivio@redhat.com>]

On Wed, 29 Nov 2023 14:46:09 +0100
Stefano Brivio <sbrivio@redhat.com> wrote:

> On 32-bit architectures, it's a regular int. C99 introduced ptrdiff_t
> for this case, with a matching length modifier, 't'.
> 
> Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
> ---
>  tcp.c        | 39 +++++++++++++++++++++------------------
>  tcp_splice.c | 14 +++++++-------
>  2 files changed, 28 insertions(+), 25 deletions(-)
> 
> diff --git a/tcp.c b/tcp.c
> index 44468ca..c32c9cb 100644
> --- a/tcp.c
> +++ b/tcp.c
> @@ -727,7 +727,7 @@ static void tcp_timer_ctl(const struct ctx *c, struct tcp_tap_conn *conn)
>  		it.it_value.tv_sec = ACT_TIMEOUT;
>  	}
>  
> -	debug("TCP: index %li, timer expires in %lu.%03lus", CONN_IDX(conn),
> +	debug("TCP: index %ti, timer expires in %lu.%03lus", CONN_IDX(conn),
>
> [...]

Oops, I just realised this clashes with your "[PATCH v2 03/11] flow,
tcp: Consolidate flow pointer<->index helpers".

There, however, I guess that the new flow_idx() should return ptrdiff_t,
which is signed.

I can drop this patch if you re-spin it (assuming it makes sense to
you), or I can adapt it on top of your patch -- whatever is most
convenient for you.

-- 
Stefano