From: David Gibson <david@gibson.dropbear.id.au>
To: passt-dev@passt.top, Stefano Brivio <sbrivio@redhat.com>
Cc: David Gibson <david@gibson.dropbear.id.au>
Subject: [PATCH v3 00/16] Introduce unified flow table, first steps
Date: Thu, 30 Nov 2023 13:02:06 +1100 [thread overview]
Message-ID: <20231130020222.4056647-1-david@gibson.dropbear.id.au> (raw)
Here's my latest revision of some of the basics of the flow table. So
far it's basically just a renaming of the existing TCP connection
table, along with some associated helpers. It's used for some new
logging infrastructure, but otherwise doesn't really function any
differently.
However, this subset of the flow table work no longer bloats
flow/connection entries over a single cache line. That removes the
most prominent drawback of earlier revisions, meaning I think this
series is ready for merge now. Doing so will mean the later series
making more substantive changes to the flow behaviour are simpler.
Tested on top of the patch updating shell prompt escape handling, but
should be independent of it.
Changes since v2:
* Added a patch to only use C11 static_assert(), not C23
static_assert() (needed for next change) [1/16]
* Better handling of the bounds on valid values of enum flow_type
[2/16]
* No longer introduce an additional C23 style static_assert() [8/16]
* Add fix for overly long guestfish commands (needed for next change)
[13/16]
* Added a patch supporting names for pifs [14/16]
* Added patches with some further TCP reworks in preparation for the
general flow table [15-16/16]
Changes since v1:
* Removed a inaccurate stale comment
* Added doc comment to FLOW() macro
* Added new patches cleaning up signedness of 'side' variables
* Added new patches introducing "sidx"s (flow+side indices)
David Gibson (16):
treewide: Add messages to static_assert() calls
flow, tcp: Generalise connection types
flow, tcp: Move TCP connection table to unified flow table
flow, tcp: Consolidate flow pointer<->index helpers
util: MAX_FROM_BITS() should be unsigned
flow: Make unified version of flow table compaction
flow, tcp: Add logging helpers for connection related messages
flow: Introduce 'sidx' type to represent one side of one flow
tcp: Remove unneccessary bounds check in tcp_timer_handler()
flow,tcp: Generalise TCP epoll_ref to generic flows
tcp_splice: Use unsigned to represent side
flow,tcp: Use epoll_ref type including flow and side
test: Avoid hitting guestfish command length limits
pif: Add helpers to get the name of a pif
tcp: "TCP" hash secret doesn't need to be TCP specific
tcp: Don't defer hash table removal
Makefile | 15 +-
flow.c | 86 +++++++++++
flow.h | 74 ++++++++++
flow_table.h | 86 +++++++++++
inany.h | 6 +-
passt.c | 40 ++++++
passt.h | 15 +-
pif.c | 21 +++
pif.h | 19 +++
tcp.c | 288 ++++++++++++++++---------------------
tcp.h | 7 -
tcp_conn.h | 46 ++----
tcp_splice.c | 128 +++++++----------
tcp_splice.h | 2 +-
test/prepare-distro-img.sh | 2 +-
util.h | 2 +-
16 files changed, 540 insertions(+), 297 deletions(-)
create mode 100644 flow.c
create mode 100644 flow.h
create mode 100644 flow_table.h
create mode 100644 pif.c
--
2.43.0
next reply other threads:[~2023-11-30 2:02 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-30 2:02 David Gibson [this message]
2023-11-30 2:02 ` [PATCH v3 01/16] treewide: Add messages to static_assert() calls David Gibson
2023-11-30 2:02 ` [PATCH v3 02/16] flow, tcp: Generalise connection types David Gibson
2023-11-30 2:02 ` [PATCH v3 03/16] flow, tcp: Move TCP connection table to unified flow table David Gibson
2023-11-30 2:02 ` [PATCH v3 04/16] flow, tcp: Consolidate flow pointer<->index helpers David Gibson
2023-11-30 2:02 ` [PATCH v3 05/16] util: MAX_FROM_BITS() should be unsigned David Gibson
2023-11-30 2:02 ` [PATCH v3 06/16] flow: Make unified version of flow table compaction David Gibson
2023-11-30 2:02 ` [PATCH v3 07/16] flow, tcp: Add logging helpers for connection related messages David Gibson
2023-11-30 2:02 ` [PATCH v3 08/16] flow: Introduce 'sidx' type to represent one side of one flow David Gibson
2023-12-02 4:35 ` Stefano Brivio
2023-11-30 2:02 ` [PATCH v3 09/16] tcp: Remove unneccessary bounds check in tcp_timer_handler() David Gibson
2023-11-30 2:02 ` [PATCH v3 10/16] flow,tcp: Generalise TCP epoll_ref to generic flows David Gibson
2023-11-30 2:02 ` [PATCH v3 11/16] tcp_splice: Use unsigned to represent side David Gibson
2023-11-30 2:02 ` [PATCH v3 12/16] flow,tcp: Use epoll_ref type including flow and side David Gibson
2023-11-30 2:02 ` [PATCH v3 13/16] test: Avoid hitting guestfish command length limits David Gibson
2023-11-30 2:02 ` [PATCH v3 14/16] pif: Add helpers to get the name of a pif David Gibson
2023-11-30 12:45 ` Stefano Brivio
2023-12-01 0:08 ` David Gibson
2023-11-30 2:02 ` [PATCH v3 15/16] tcp: "TCP" hash secret doesn't need to be TCP specific David Gibson
2023-11-30 2:02 ` [PATCH v3 16/16] tcp: Don't defer hash table removal David Gibson
2023-11-30 12:45 ` Stefano Brivio
2023-12-01 0:07 ` David Gibson
2023-12-02 4:34 ` Stefano Brivio
2023-12-04 0:43 ` David Gibson
2023-12-04 9:54 ` [PATCH v3 00/16] Introduce unified flow table, first steps Stefano Brivio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231130020222.4056647-1-david@gibson.dropbear.id.au \
--to=david@gibson.dropbear.id.au \
--cc=passt-dev@passt.top \
--cc=sbrivio@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).