From: Stefano Brivio <sbrivio@redhat.com>
To: Laurent Vivier <lvivier@redhat.com>
Cc: David Gibson <david@gibson.dropbear.id.au>, passt-dev@passt.top
Subject: Re: [PATCH] tcp: remove useless assignment
Date: Mon, 4 Dec 2023 10:54:17 +0100 [thread overview]
Message-ID: <20231204105417.484cadaf@elisabeth> (raw)
In-Reply-To: <ZWajOBkqAwrtBrj0@zatzit>
On Wed, 29 Nov 2023 13:34:32 +1100
David Gibson <david@gibson.dropbear.id.au> wrote:
> On Tue, Nov 28, 2023 at 05:54:23PM +0100, Laurent Vivier wrote:
> > In tcp_send_flag(), a4826ee04b76 has replaced:
> >
> > th->doff = sizeof(*th) / 4;
> > th->doff += OPT_MSS_LEN / 4;
> > th->doff += (1 + OPT_WS_LEN) / 4;
> >
> > by
> >
> > optlen = OPT_MSS_LEN + 1 + OPT_WS_LEN;
> > th->doff = (sizeof(*th) + optlen) / 4;
> >
> > but forgot to remove the useless "th->doff += (1 + OPT_WS_LEN) / 4;"
> >
> > Fixes: a4826ee04b76 ("tcp: Defer and coalesce all segments with no data (flags) to handler")
> > Cc: sbrivio@redhat.com
> > Signed-off-by: Laurent Vivier <lvivier@redhat.com>
>
> Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
Applied.
--
Stefano
prev parent reply other threads:[~2023-12-04 9:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-28 16:54 [PATCH] tcp: remove useless assignment Laurent Vivier
2023-11-29 2:34 ` David Gibson
2023-12-04 9:54 ` Stefano Brivio [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231204105417.484cadaf@elisabeth \
--to=sbrivio@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=lvivier@redhat.com \
--cc=passt-dev@passt.top \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).