From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTP id E419B5A027F for ; Mon, 4 Dec 2023 10:54:24 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1701683663; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eHQJu8vao30/jjO/UJUXusCknfoeKeecyPzso/kg69M=; b=fpAuanLcDuBzAsjK9+iMegUSRZ+nCXhOPo9S01uh0VpX9VystXvbpSZnC75qgwz5U5/ynR UPfjt3b3jlYjFEnxWG6wsMBrEZJNt4CtdCJeJT5i96wp9iMGFgwiimKcuq8Wzktk5+Puv+ AmNIYtOxe2a8rf1CkuymgNU1DJivoDI= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-360-ZT12zI3CN7GHNwfbFSHWnw-1; Mon, 04 Dec 2023 04:54:20 -0500 X-MC-Unique: ZT12zI3CN7GHNwfbFSHWnw-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 1AA5A3C025B8; Mon, 4 Dec 2023 09:54:20 +0000 (UTC) Received: from elisabeth (unknown [10.39.208.34]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2D9082166B27; Mon, 4 Dec 2023 09:54:18 +0000 (UTC) Date: Mon, 4 Dec 2023 10:54:17 +0100 From: Stefano Brivio To: Laurent Vivier Subject: Re: [PATCH] tcp: remove useless assignment Message-ID: <20231204105417.484cadaf@elisabeth> In-Reply-To: References: <20231128165423.1845799-1-lvivier@redhat.com> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: WVPEHOSMLJSRJBQHMS3JOGXLG2Y47PPF X-Message-ID-Hash: WVPEHOSMLJSRJBQHMS3JOGXLG2Y47PPF X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: David Gibson , passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed, 29 Nov 2023 13:34:32 +1100 David Gibson wrote: > On Tue, Nov 28, 2023 at 05:54:23PM +0100, Laurent Vivier wrote: > > In tcp_send_flag(), a4826ee04b76 has replaced: > > > > th->doff = sizeof(*th) / 4; > > th->doff += OPT_MSS_LEN / 4; > > th->doff += (1 + OPT_WS_LEN) / 4; > > > > by > > > > optlen = OPT_MSS_LEN + 1 + OPT_WS_LEN; > > th->doff = (sizeof(*th) + optlen) / 4; > > > > but forgot to remove the useless "th->doff += (1 + OPT_WS_LEN) / 4;" > > > > Fixes: a4826ee04b76 ("tcp: Defer and coalesce all segments with no data (flags) to handler") > > Cc: sbrivio@redhat.com > > Signed-off-by: Laurent Vivier > > Reviewed-by: David Gibson Applied. -- Stefano