From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTP id C69925A027F for ; Mon, 4 Dec 2023 10:54:31 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1701683670; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oQOWirWIAeB2ghaPz2kHKdTMDN6ZbJK/TJ+q1UZwxxI=; b=hCLkZlH1xKX1tWyRZtKayCcng0/LzwpyVEFnEMPa0gU/ux/1xaKNV9ylhqjcrGrFWbnrvS 7vp9EHpWnZbMOjlUolZoKMzbQ2N4Fr6UWDX3t4GuzInTwzgEAzFNq8ISGiaPoTCar41HzY wcCEuF1SlLVBqt5uJSWJM7I6OgJAe3s= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-61-HSY5bmvGOReQgikVRJ3Azw-1; Mon, 04 Dec 2023 04:54:27 -0500 X-MC-Unique: HSY5bmvGOReQgikVRJ3Azw-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 1A7FB3C025B8; Mon, 4 Dec 2023 09:54:27 +0000 (UTC) Received: from elisabeth (unknown [10.39.208.34]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4BF47492BFC; Mon, 4 Dec 2023 09:54:26 +0000 (UTC) Date: Mon, 4 Dec 2023 10:54:24 +0100 From: Stefano Brivio To: David Gibson Subject: Re: [PATCH v3 00/16] Introduce unified flow table, first steps Message-ID: <20231204105424.22d55714@elisabeth> In-Reply-To: <20231130020222.4056647-1-david@gibson.dropbear.id.au> References: <20231130020222.4056647-1-david@gibson.dropbear.id.au> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: FLGBJJUPW3A75XUPXO4IA5UXWIZN7IEJ X-Message-ID-Hash: FLGBJJUPW3A75XUPXO4IA5UXWIZN7IEJ X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Thu, 30 Nov 2023 13:02:06 +1100 David Gibson wrote: > Here's my latest revision of some of the basics of the flow table. So > far it's basically just a renaming of the existing TCP connection > table, along with some associated helpers. It's used for some new > logging infrastructure, but otherwise doesn't really function any > differently. > > However, this subset of the flow table work no longer bloats > flow/connection entries over a single cache line. That removes the > most prominent drawback of earlier revisions, meaning I think this > series is ready for merge now. Doing so will mean the later series > making more substantive changes to the flow behaviour are simpler. > > Tested on top of the patch updating shell prompt escape handling, but > should be independent of it. > > Changes since v2: > * Added a patch to only use C11 static_assert(), not C23 > static_assert() (needed for next change) [1/16] > * Better handling of the bounds on valid values of enum flow_type > [2/16] > * No longer introduce an additional C23 style static_assert() [8/16] > * Add fix for overly long guestfish commands (needed for next change) > [13/16] > * Added a patch supporting names for pifs [14/16] > * Added patches with some further TCP reworks in preparation for the > general flow table [15-16/16] > Changes since v1: > * Removed a inaccurate stale comment > * Added doc comment to FLOW() macro > * Added new patches cleaning up signedness of 'side' variables > * Added new patches introducing "sidx"s (flow+side indices) Applied. -- Stefano