From: David Gibson <david@gibson.dropbear.id.au>
To: passt-dev@passt.top, Stefano Brivio <sbrivio@redhat.com>
Cc: David Gibson <david@gibson.dropbear.id.au>
Subject: [PATCH] checksum: Don't use linux/icmp.h when netinet/ip_icmp.h will do
Date: Tue, 5 Dec 2023 20:16:17 +1100 [thread overview]
Message-ID: <20231205091617.216850-1-david@gibson.dropbear.id.au> (raw)
In most places where we need to get ICMP definitions, we get them from
<netinet/ip_icmp.h>. However in checksum.c we instead include
<linux/icmp.h>. Change it to use <netinet/ip_icmp.h> for consistency.
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
---
checksum.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/checksum.c b/checksum.c
index 03b8a7c..f21c9b7 100644
--- a/checksum.c
+++ b/checksum.c
@@ -49,11 +49,11 @@
#include <arpa/inet.h>
#include <netinet/ip.h>
#include <netinet/tcp.h>
+#include <netinet/ip_icmp.h>
#include <stddef.h>
#include <stdint.h>
#include <linux/udp.h>
-#include <linux/icmp.h>
#include <linux/icmpv6.h>
/* Checksums are optional for UDP over IPv4, so we usually just set
--
@@ -49,11 +49,11 @@
#include <arpa/inet.h>
#include <netinet/ip.h>
#include <netinet/tcp.h>
+#include <netinet/ip_icmp.h>
#include <stddef.h>
#include <stdint.h>
#include <linux/udp.h>
-#include <linux/icmp.h>
#include <linux/icmpv6.h>
/* Checksums are optional for UDP over IPv4, so we usually just set
--
2.43.0
next reply other threads:[~2023-12-05 12:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-05 9:16 David Gibson [this message]
2023-12-27 20:24 ` [PATCH] checksum: Don't use linux/icmp.h when netinet/ip_icmp.h will do Stefano Brivio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231205091617.216850-1-david@gibson.dropbear.id.au \
--to=david@gibson.dropbear.id.au \
--cc=passt-dev@passt.top \
--cc=sbrivio@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).