From: David Gibson <david@gibson.dropbear.id.au>
To: Stefano Brivio <sbrivio@redhat.com>, passt-dev@passt.top
Cc: David Gibson <david@gibson.dropbear.id.au>
Subject: [PATCH v2 0/4] TCP hash table changes, in preparation for flow table
Date: Thu, 7 Dec 2023 16:53:49 +1100 [thread overview]
Message-ID: <20231207055353.1245933-1-david@gibson.dropbear.id.au> (raw)
I now have an in-progress draft of a unified hash table to go with the
unified flow table. This turns out to be easier if we first make some
preliminary changes to the structure of the TCP hash table. So, here
are those.
Changes since v1:
* Use while loops instead of some equivalent, but hard to read for
loops for the hash probing.
* Switch from probing forwards through hash buckets to probing
backwards. This makes the code closer to the version in Knuth its
based on, and thus easier to see if we've made a mistake in
adaptation.
* Improve the helpers for modular arithmetic in use
* Correct an error where we had things exactly the wrong way around
when finding entries to move during removal.
* Add a patch fixing a conceptual / documentation problem in some
adjacent code
David Gibson (4):
tcp: Fix conceptually incorrect byte-order switch in tcp_tap_handler()
tcp: Switch hash table to linear probing instead of chaining
tcp: Implement hash table with indices rather than pointers
tcp: Don't account for hash table size in tcp_hash()
flow.h | 11 +++++
tcp.c | 143 ++++++++++++++++++++++++++++-------------------------
tcp_conn.h | 2 -
util.h | 28 +++++++++++
4 files changed, 114 insertions(+), 70 deletions(-)
--
2.43.0
next reply other threads:[~2023-12-07 5:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-07 5:53 David Gibson [this message]
2023-12-07 5:53 ` [PATCH v2 1/4] tcp: Fix conceptually incorrect byte-order switch in tcp_tap_handler() David Gibson
2023-12-07 5:53 ` [PATCH v2 2/4] tcp: Switch hash table to linear probing instead of chaining David Gibson
2023-12-07 5:53 ` [PATCH v2 3/4] tcp: Implement hash table with indices rather than pointers David Gibson
2023-12-07 5:53 ` [PATCH v2 4/4] tcp: Don't account for hash table size in tcp_hash() David Gibson
2023-12-27 20:23 ` [PATCH v2 0/4] TCP hash table changes, in preparation for flow table Stefano Brivio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231207055353.1245933-1-david@gibson.dropbear.id.au \
--to=david@gibson.dropbear.id.au \
--cc=passt-dev@passt.top \
--cc=sbrivio@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).