From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from gandalf.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by passt.top (Postfix) with ESMTPS id 629655A0274 for ; Thu, 7 Dec 2023 15:31:48 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202312; t=1701959502; bh=iD+BMNa5djROs8zxF1vCs0rsR20XnLQrWdKUaLWkOXE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Nv9IEFfM1g6EgOpZvecy/LpQuPy/cyAjzptnq+Kz5Mo87cWnHt4rev3BLl7EIrn4u +rldcGF2k/17KSaB6s2mewiUWt/PsYtBoYAlz/OCz3amYdG7umR7EmF4HjaE9c0Vql t8J8hpAm5X30O4PJGQcs0h0tkkqy88hS9fSnLG3nD8cRSsq1XrUPDh/C7Z67xttgWl jFiXNa0Kww3iRDdxiKZRK2B2Hpe5lsdw1BwfvuqEtEDHCVMQK0F1ukTFDOYKQ27FtR LxHoe6+6Mhqdja0tiPmmUlG8JP8oy0B2EebhgMT1I5jxZxEaPIVvrXcHIX8xpW+LV+ BITvjkIt3pzaQ== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4SmGtQ1cC0z4xPQ; Fri, 8 Dec 2023 01:31:42 +1100 (AEDT) From: David Gibson To: Stefano Brivio , passt-dev@passt.top Subject: [PATCH 4/8] util: Use htonl_constant() in more places Date: Fri, 8 Dec 2023 01:31:36 +1100 Message-ID: <20231207143140.1851378-5-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231207143140.1851378-1-david@gibson.dropbear.id.au> References: <20231207143140.1851378-1-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Message-ID-Hash: SXEQA7XXTETTRLALBSATUSOP4FW3XCHY X-Message-ID-Hash: SXEQA7XXTETTRLALBSATUSOP4FW3XCHY X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: David Gibson X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: We might as well when we're passing a known constant value, giving the compiler the best chance to optimise things away. Signed-off-by: David Gibson --- util.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/util.h b/util.h index 6b11951..b4ad32d 100644 --- a/util.h +++ b/util.h @@ -111,9 +111,9 @@ #endif #define IN4_IS_ADDR_UNSPECIFIED(a) \ - ((a)->s_addr == htonl(INADDR_ANY)) + ((a)->s_addr == htonl_constant(INADDR_ANY)) #define IN4_IS_ADDR_BROADCAST(a) \ - ((a)->s_addr == htonl(INADDR_BROADCAST)) + ((a)->s_addr == htonl_constant(INADDR_BROADCAST)) #define IN4_IS_ADDR_LOOPBACK(a) \ (ntohl((a)->s_addr) >> IN_CLASSA_NSHIFT == IN_LOOPBACKNET) #define IN4_IS_ADDR_MULTICAST(a) \ -- 2.43.0