From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from gandalf.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by passt.top (Postfix) with ESMTPS id 5DB845A0272 for ; Thu, 14 Dec 2023 03:15:49 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202312; t=1702520145; bh=I0SMKnJnaGwMxH3qtTZESbyig5WL8SYmxEjFAQmr/SA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=TS+C+SOuNXoeZ0uwww21V2bUPmd+Ty0uM1jDIEvnUwy39CSHzu/KUR2/fld1PU2wj 2Ll9yIOv3yEDq/ewn/koxjTn8V/7tNgWeOJcdtGnEyrRG/q2zLvqS3rqYyZ+UTo4Wr 0LpTCdc/TCXBQUupvHhOhl+kULc3fFoHnnNUpNGByiRvggDUduRh2D3Dy4bitL4l+v 5te4blz/tc8xaUwQjGzIFvs6toNbtrZQO/LqdTYUT2MXvWyg6ALAcYHsCjarZF+DNv 9CfnWDf6miB6DxthVr1kiygvFtQ7xxApSThcisbF7tXOx9KGyKETWKTX4PuGaXFoOH 386IOAeWhwdlg== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4SrGD113Jjz4wcJ; Thu, 14 Dec 2023 13:15:45 +1100 (AEDT) From: David Gibson To: passt-dev@passt.top, Stefano Brivio Subject: [PATCH 1/8] flow: Make flow_table.h #include the protocol specific headers it needs Date: Thu, 14 Dec 2023 13:15:34 +1100 Message-ID: <20231214021541.3925825-2-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231214021541.3925825-1-david@gibson.dropbear.id.au> References: <20231214021541.3925825-1-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Message-ID-Hash: JUIXGM5P3HSFUFWLDXGFJI3LMCZQQLZR X-Message-ID-Hash: JUIXGM5P3HSFUFWLDXGFJI3LMCZQQLZR X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: David Gibson X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: flow_table.h, the lower level flow header relies on having the struct definitions for every protocol specific flow type - so far that means tcp_conn.h. It doesn't include it itself, so tcp_conn.h must be included before flow_table.h. That's ok for now, but as we use the flow table for more things, flow_table.h will need the structs for all of them, which means the protocol specific .c files would need to include tcp_conn.h _and_ the equivalents for every other flow type before flow_table.h every time, which is weird. So, although we *mostly* lean towards the include style where .c files need to handle the include dependencies, in this case it makes more sense to have flow_table.h include all the protocol specific headers it needs. Signed-off-by: David Gibson --- flow.c | 1 - flow_table.h | 2 ++ tcp.c | 1 - tcp_splice.c | 1 - 4 files changed, 2 insertions(+), 3 deletions(-) diff --git a/flow.c b/flow.c index d24726d..a1c0a34 100644 --- a/flow.c +++ b/flow.c @@ -14,7 +14,6 @@ #include "siphash.h" #include "inany.h" #include "flow.h" -#include "tcp_conn.h" #include "flow_table.h" const char *flow_type_str[] = { diff --git a/flow_table.h b/flow_table.h index 0dee66f..e805f10 100644 --- a/flow_table.h +++ b/flow_table.h @@ -7,6 +7,8 @@ #ifndef FLOW_TABLE_H #define FLOW_TABLE_H +#include "tcp_conn.h" + /** * union flow - Descriptor for a logical packet flow (e.g. connection) * @f: Fields common between all variants diff --git a/tcp.c b/tcp.c index f506cfd..ce53ee0 100644 --- a/tcp.c +++ b/tcp.c @@ -298,7 +298,6 @@ #include "inany.h" #include "flow.h" -#include "tcp_conn.h" #include "flow_table.h" /* Sides of a flow as we use them in "tap" connections */ diff --git a/tcp_splice.c b/tcp_splice.c index 69ea79d..052f989 100644 --- a/tcp_splice.c +++ b/tcp_splice.c @@ -56,7 +56,6 @@ #include "inany.h" #include "flow.h" -#include "tcp_conn.h" #include "flow_table.h" #define MAX_PIPE_SIZE (8UL * 1024 * 1024) -- 2.43.0