From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from gandalf.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by passt.top (Postfix) with ESMTPS id 4F8685A027C for ; Mon, 18 Dec 2023 08:40:28 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202312; t=1702885220; bh=Rk08fz3k3xW9XK2UtVNgO+lMv2VeO+ktSwlK8zgn3rM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=p5jjtig/JGajqWauOrYjIep8G4Iht4FEuBAdx4yj0caFx+XothZz+7vye2ego8juu 7dUDzaB824Hqh05HHVnBgYbZ/9ZAlehHRd30yNz/ZWejq7trn+QlJKzSgF5f/myOf5 Td8GpFR/vXtI3CrojW+xf/C/NJq4poJhsAw8RHVHCTr5tEQEHYcOO/FRpL0K4XXx98 I40RFJIOmhqLmLnQ1S2p2hwTwTTat925BIle+oMuIzTwnIM4g8KiKvyMVZsbvpHsYh ZiMVZdBMRMbGmWgaYue3p37h2x6nigAxT0+qpMEXGd4rWIB15tzBBK9v3IaVKmxxJU G2EgmWYTLrnpA== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4StsDh2yFRz4xgv; Mon, 18 Dec 2023 18:40:20 +1100 (AEDT) From: David Gibson To: Stefano Brivio , passt-dev@passt.top Subject: [PATCH 10/11] icmp: Warn on receive errors from ping sockets Date: Mon, 18 Dec 2023 18:40:16 +1100 Message-ID: <20231218074017.985092-11-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231218074017.985092-1-david@gibson.dropbear.id.au> References: <20231218074017.985092-1-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Message-ID-Hash: PRAJSEX6LFPMFGUDCP23WHJAQFRRFP2X X-Message-ID-Hash: PRAJSEX6LFPMFGUDCP23WHJAQFRRFP2X X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: David Gibson X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Currently we silently ignore an errors receiving a packet from a ping socket. We don't expect that to happen, so it's probably worth reporting if it does. Signed-off-by: David Gibson --- icmp.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/icmp.c b/icmp.c index b26c61f..7e698f3 100644 --- a/icmp.c +++ b/icmp.c @@ -81,8 +81,11 @@ void icmp_sock_handler(const struct ctx *c, int af, union epoll_ref ref) return; n = recvfrom(ref.fd, buf, sizeof(buf), 0, &sr.sa, &sl); - if (n < 0) + if (n < 0) { + warn("%s: recvfrom() error on ping socket: %s", + pname, strerror(errno)); return; + } if (af == AF_INET) { struct icmphdr *ih4 = (struct icmphdr *)buf; -- 2.43.0