From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from gandalf.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by passt.top (Postfix) with ESMTPS id 01F6D5A0274 for ; Thu, 21 Dec 2023 07:53:33 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202312; t=1703141610; bh=5fqT/KFZ0VISXFfCYww9cyJ8EntFlTsKvtd+tlk+DhE=; h=From:To:Cc:Subject:Date:From; b=lgbi3byc2I8ctJfQhJONNnhtDd4IMjTx2iUkr0VJHn3NU2A2sLmeekhFTmNAcDhDS o8dZ5+3bB6JCsiM9bzZQ8jMY4CdlbhZqPlNAY3aJV6aq+B3bM4EYUaFac/rDZBWBml zjb8149yutNyaDYxymadchr02//N4DB/1ZaKekr6Ls1eX1cMXUUVfn8gFwswzv0h8p JYuMWghKrQZNHQqj8xB4pJCkh3fHqOlq/GY38Yb/zzwnq8sVyiq/hwu/lQei5DiIeo k1+pwDZNS8t7l7AlJUtSbPDRHMlluQ9aROKudqqJIBQM6efNJBQ6J4ZhHPvn+8XWe0 nyAx2qq70L9GQ== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4Swh3G3wssz4xQj; Thu, 21 Dec 2023 17:53:30 +1100 (AEDT) From: David Gibson To: Stefano Brivio , passt-dev@passt.top Subject: [PATCH v2 00/12] RFC: ICMP reworks preliminary to flow table integration Date: Thu, 21 Dec 2023 17:53:15 +1100 Message-ID: <20231221065327.1307827-1-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.43.0 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Message-ID-Hash: FLAHMHYZEG2DZP5BR6M2DV6GQ43H3IQM X-Message-ID-Hash: FLAHMHYZEG2DZP5BR6M2DV6GQ43H3IQM X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: David Gibson X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: As with TCP, it turns out that there are a bunch of clean ups and reworks to the ICMP code which will make integration with the flow table easier, even before introducing a non-trivial version of the flow table itself. Based on the flow based dispatch/allocation, and bind/addressing cleanup series. Changes since v1: * Rebased on newer version of flow dispatch & allocation series * Added 12/12 splitting out close and new sequence functions David Gibson (12): checksum: Don't use linux/icmp.h when netinet/ip_icmp.h will do icmp: Don't set "port" on destination sockaddr for ping sockets icmp: Remove redundant initialisation of sendto() address icmp: Don't attempt to handle "wrong direction" ping socket traffic icmp: Don't attempt to match host IDs to guest IDs icmp: Use -1 to represent "missing" sockets icmp: Simplify socket expiry scanning icmp: Share more between IPv4 and IPv6 paths in icmp_tap_handler() icmp: Consolidate icmp_sock_handler() with icmpv6_sock_handler() icmp: Warn on receive errors from ping sockets icmp: Validate packets received on ping sockets icmp: Dedicated functions for starting and closing ping sequences checksum.c | 2 +- icmp.c | 326 ++++++++++++++++++++++++++--------------------------- icmp.h | 5 +- passt.c | 4 +- 4 files changed, 164 insertions(+), 173 deletions(-) -- 2.43.0