From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from gandalf.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by passt.top (Postfix) with ESMTPS id C748D5A0271 for ; Thu, 21 Dec 2023 07:53:32 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202312; t=1703141610; bh=Y0V2/1wX0HsT1LreClOcgwEset4GladTLBq3KJQsLNI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=qQX3yAXyAxOHIWSJZCAR0J75O+5K5jTN7BB79Ee8I1I0iwO/l3O9uvZY8Ja1IMgs/ TkIdcOjLpgRgouY7/kmHMHIR0r88M1QUqC4Dx5D1HP1Dzhc9/k/kRzGwnHUPi+CKR8 4yMFwRP/uKRDWcNNoIK0YlZ+UB3ag/JVccZrcT+DDXBzG1/RAghqmRkK+2PR0waFVz hNA6CnxWAP4u//yq5KWp+jo75ISjyxXiRVSzcHinPsREdR2eBnfH7GyzHxN3aTjHgM skwVGrtM9Kx21f0UNqTjyjqBRpghxGEk0iJ7uZIAgWHA2UnTla46Od7RgmuI8UVGZ7 pAz0XYw7Z3mYg== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4Swh3G4Vtqz4xRj; Thu, 21 Dec 2023 17:53:30 +1100 (AEDT) From: David Gibson To: Stefano Brivio , passt-dev@passt.top Subject: [PATCH v2 03/12] icmp: Remove redundant initialisation of sendto() address Date: Thu, 21 Dec 2023 17:53:18 +1100 Message-ID: <20231221065327.1307827-4-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231221065327.1307827-1-david@gibson.dropbear.id.au> References: <20231221065327.1307827-1-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Message-ID-Hash: MOBCQFXFELLW5NYMBFO2SJQW6IEO747Z X-Message-ID-Hash: MOBCQFXFELLW5NYMBFO2SJQW6IEO747Z X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: David Gibson X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: We initialise the address portion of the sockaddr for sendto() to the unspecified address, but then always overwrite it with the actual destination address before we call the sendto(). Signed-off-by: David Gibson --- icmp.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/icmp.c b/icmp.c index d3e5bc6..c745b7b 100644 --- a/icmp.c +++ b/icmp.c @@ -169,7 +169,6 @@ int icmp_tap_handler(const struct ctx *c, uint8_t pif, int af, if (af == AF_INET) { struct sockaddr_in sa = { .sin_family = AF_INET, - .sin_addr = IN4ADDR_ANY_INIT, }; union icmp_epoll_ref iref; struct icmphdr *ih; @@ -213,7 +212,6 @@ int icmp_tap_handler(const struct ctx *c, uint8_t pif, int af, } else if (af == AF_INET6) { struct sockaddr_in6 sa = { .sin6_family = AF_INET6, - .sin6_addr = IN6ADDR_ANY_INIT, .sin6_scope_id = c->ifi6, }; union icmp_epoll_ref iref; -- 2.43.0