Re: [PATCH v2 0/4] TCP hash table changes, in preparation for flow table

[Stefano Brivio <sbrivio@redhat.com>]

On Thu,  7 Dec 2023 16:53:49 +1100
David Gibson <david@gibson.dropbear.id.au> wrote:

> I now have an in-progress draft of a unified hash table to go with the
> unified flow table.  This turns out to be easier if we first make some
> preliminary changes to the structure of the TCP hash table.  So, here
> are those.
> 
> Changes since v1:
>  * Use while loops instead of some equivalent, but hard to read for
>    loops for the hash probing.
>  * Switch from probing forwards through hash buckets to probing
>    backwards.  This makes the code closer to the version in Knuth its
>    based on, and thus easier to see if we've made a mistake in
>    adaptation.
>  * Improve the helpers for modular arithmetic in use
>  * Correct an error where we had things exactly the wrong way around
>    when finding entries to move during removal.
>  * Add a patch fixing a conceptual / documentation problem in some
>    adjacent code
> 
> David Gibson (4):
>   tcp: Fix conceptually incorrect byte-order switch in tcp_tap_handler()
>   tcp: Switch hash table to linear probing instead of chaining
>   tcp: Implement hash table with indices rather than pointers
>   tcp: Don't account for hash table size in tcp_hash()

Applied.

-- 
Stefano