* [PATCH] checksum: Don't use linux/icmp.h when netinet/ip_icmp.h will do
@ 2023-12-05 9:16 David Gibson
2023-12-27 20:24 ` Stefano Brivio
0 siblings, 1 reply; 2+ messages in thread
From: David Gibson @ 2023-12-05 9:16 UTC (permalink / raw)
To: passt-dev, Stefano Brivio; +Cc: David Gibson
In most places where we need to get ICMP definitions, we get them from
<netinet/ip_icmp.h>. However in checksum.c we instead include
<linux/icmp.h>. Change it to use <netinet/ip_icmp.h> for consistency.
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
---
checksum.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/checksum.c b/checksum.c
index 03b8a7c..f21c9b7 100644
--- a/checksum.c
+++ b/checksum.c
@@ -49,11 +49,11 @@
#include <arpa/inet.h>
#include <netinet/ip.h>
#include <netinet/tcp.h>
+#include <netinet/ip_icmp.h>
#include <stddef.h>
#include <stdint.h>
#include <linux/udp.h>
-#include <linux/icmp.h>
#include <linux/icmpv6.h>
/* Checksums are optional for UDP over IPv4, so we usually just set
--
@@ -49,11 +49,11 @@
#include <arpa/inet.h>
#include <netinet/ip.h>
#include <netinet/tcp.h>
+#include <netinet/ip_icmp.h>
#include <stddef.h>
#include <stdint.h>
#include <linux/udp.h>
-#include <linux/icmp.h>
#include <linux/icmpv6.h>
/* Checksums are optional for UDP over IPv4, so we usually just set
--
2.43.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] checksum: Don't use linux/icmp.h when netinet/ip_icmp.h will do
2023-12-05 9:16 [PATCH] checksum: Don't use linux/icmp.h when netinet/ip_icmp.h will do David Gibson
@ 2023-12-27 20:24 ` Stefano Brivio
0 siblings, 0 replies; 2+ messages in thread
From: Stefano Brivio @ 2023-12-27 20:24 UTC (permalink / raw)
To: David Gibson; +Cc: passt-dev
On Tue, 5 Dec 2023 20:16:17 +1100
David Gibson <david@gibson.dropbear.id.au> wrote:
> In most places where we need to get ICMP definitions, we get them from
> <netinet/ip_icmp.h>. However in checksum.c we instead include
> <linux/icmp.h>. Change it to use <netinet/ip_icmp.h> for consistency.
>
> Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Applied.
--
Stefano
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-12-27 20:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-12-05 9:16 [PATCH] checksum: Don't use linux/icmp.h when netinet/ip_icmp.h will do David Gibson
2023-12-27 20:24 ` Stefano Brivio
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).