From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTP id D06595A026F for ; Wed, 27 Dec 2023 21:25:48 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1703708747; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ukcNcLK5H/XL/IQ2WfeX6SBcgzq6rj0L3Q6FDbunQ0g=; b=C3DmfzgJN+I/mz/frD3M2KrKQeRQGNRPKsmTk9/xUeHmPNGzE0FFTgOUxw3C2qbJn79LaF aSP8rfTxKxCnDsO41ZxL3R/83S+f3Y+TXr+/aM/uktUxxNJ0P3P5/LaK3XBULxYEmOiz4r mFwWajQCqyRPMlK7T+TB44JsqKEhdtk= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-541-D--K6fG8PkudXNcS5ilEKQ-1; Wed, 27 Dec 2023 15:25:46 -0500 X-MC-Unique: D--K6fG8PkudXNcS5ilEKQ-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id C16CD1C04B5A; Wed, 27 Dec 2023 20:25:45 +0000 (UTC) Received: from elisabeth (unknown [10.39.208.24]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BC5583C25; Wed, 27 Dec 2023 20:25:44 +0000 (UTC) Date: Wed, 27 Dec 2023 21:25:42 +0100 From: Stefano Brivio To: Laurent Vivier Subject: Re: [PATCH] tcp: make tcp_sock_set_bufsize() static (again) Message-ID: <20231227212542.06b79ba3@elisabeth> In-Reply-To: References: <20231204142311.1960715-1-lvivier@redhat.com> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: HA4DCYUHQMUYFTYRROE3XF2ORO2RV6VV X-Message-ID-Hash: HA4DCYUHQMUYFTYRROE3XF2ORO2RV6VV X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: David Gibson , passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Tue, 5 Dec 2023 11:46:10 +1100 David Gibson wrote: > On Mon, Dec 04, 2023 at 03:23:11PM +0100, Laurent Vivier wrote: > > e5eefe77435a ("tcp: Refactor to use events instead of states, split out > > spliced implementation") has exported tcp_sock_set_bufsize() to > > be able to use it in tcp_splice.c, but 6ccab72d9b40 has removed its use > > in tcp_splice.c, so we can set it static again. > > > > Fixes: 6ccab72d9b40 ("tcp: Improve handling of fallback if socket pool is empty on new splice") > > Cc: david@gibson.dropbear.id.au > > Signed-off-by: Laurent Vivier > > Reviewed-by: David Gibson Applied. -- Stefano